Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade my status to committer in contributors.json #29312

Merged
merged 1 commit into from
May 30, 2024
Merged

Upgrade my status to committer in contributors.json #29312

merged 1 commit into from
May 30, 2024

Conversation

Achierius
Copy link
Contributor

@Achierius Achierius commented May 30, 2024 •
edited by webkit-early-warning-system
Loading

@Achierius Achierius self-assigned this May 30, 2024
@Achierius Achierius added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label May 30, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 30, 2024 •
edited
Loading

EWS run on current version of this PR (hash e58153a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
  🛠 tv ✅ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

Constellation
Constellation approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 30, 2024
@Achierius @Constellation
Upgrade my status to committer in contributors.json
0455d0b 
https://bugs.webkit.org/show_bug.cgi?id=274907
rdar://129012669

Reviewed by Yusuke Suzuki.

* metadata/contributors.json:

Canonical link: https://commits.webkit.org/279530@main
@webkit-commit-queue
Copy link
Collaborator

Committed 279530@main (0455d0b): https://commits.webkit.org/279530@main

Reviewed commits have been landed. Closing PR #29312 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0455d0b into WebKit:main May 30, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 30, 2024
@JonWBedard JonWBedard added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@Achierius Achierius

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Achierius @webkit-early-warning-system @webkit-commit-queue @Constellation @JonWBedard