[container-queries] Stop forcing layout containment but force an independent formatting context #31376

karlcow · 2024-07-29T06:07:50Z

`9c47b8d`

[container-queries] Stop forcing layout containment but force an independent formatting context
https://bugs.webkit.org/show_bug.cgi?id=277122
rdar://132549134

Reviewed by NOBODY (OOPS!).

container-type does not force layout containment, but does force
an independent formatting context by CSS WG resolution on
w3c/csswg-drafts#10544

This takes into account the latest import for container queries
WPT tests formatting
web-platform-tests/wpt@27c89c6

* LayoutTests/TestExpectations:
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::firstLineBaseline const):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::establishesIndependentFormattingContext const):
(WebCore::RenderElement::hasEligibleContainmentForSizeQuery const):
* Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::usedContain const):

Co-authored-by: Tim Nguyen <ntim@apple.com>

9c47b8d

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-07-29T06:07:59Z

EWS run on previous version of this PR (hash a361626)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

karlcow · 2024-07-29T06:10:34Z

Let' start fresh.

nt1m · 2024-07-29T07:30:18Z

I think I know what's causing most of these failures:

This needs to be removed: https://searchfox.org/wubkat/rev/b36cbce69fddb7da33823f316bd8ead5bebee970/Source/WebCore/rendering/RenderElement.cpp#2507-2509

webkit-early-warning-system · 2024-07-29T08:00:31Z

EWS run on previous version of this PR (hash a694dd8)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 wincairo~~
~~🧪 bindings~~	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 wincairo-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~
	✅ 🛠 tv
	✅ 🛠 tv-sim
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-07-29T08:03:05Z

EWS run on previous version of this PR (hash 5202a1e)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-07-30T08:04:33Z

EWS run on previous version of this PR (hash 3204996)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2
	~~🛠 tv~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

karlcow · 2024-07-30T09:56:20Z

houla… what happened.

webkit-early-warning-system · 2024-07-30T10:01:22Z

EWS run on previous version of this PR (hash 66f5a44)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

karlcow · 2024-07-30T10:03:43Z

So the tests for table have been fixed, except table-cell tests which still regress. So still 8 FAIL instead of the 16 FAIL initially.
http://wpt.live/css/css-conditional/container-queries/nested-query-containers.html

Source/WebCore/rendering/RenderTable.cpp

…pendent formatting context https://bugs.webkit.org/show_bug.cgi?id=277122 rdar://132549134 Reviewed by NOBODY (OOPS!). container-type does not force layout containment, but does force an independent formatting context by CSS WG resolution on w3c/csswg-drafts#10544 This takes into account the latest import for container queries WPT tests formatting web-platform-tests/wpt@27c89c6 * LayoutTests/TestExpectations: * Source/WebCore/rendering/RenderBlock.cpp: (WebCore::RenderBlock::firstLineBaseline const): * Source/WebCore/rendering/RenderElement.cpp: (WebCore::RenderElement::establishesIndependentFormattingContext const): (WebCore::RenderElement::hasEligibleContainmentForSizeQuery const): * Source/WebCore/rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::usedContain const): Co-authored-by: Tim Nguyen <ntim@apple.com>

webkit-early-warning-system · 2024-07-31T02:53:12Z

EWS run on current version of this PR (hash 9c47b8d)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2
	✅ 🛠 tv
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/rendering/RenderBlock.cpp

bfgeek · 2024-09-27T22:53:37Z

@karlcow @nt1m - Any change you got to investigate the failure? The change in Chromium looks like its sticky - so if possible it'd be great if WebKit can follow soon.

Thanks,
Ian

karlcow · 2024-10-01T06:01:37Z

@bfgeek
@alanbaradlay asked me if he could take over 🎉
This should be more effective.

bfgeek · 2024-10-03T18:55:02Z

@karlcow @alanbaradlay - The zero table-cell + baseline isn't particularly important to the test (IMO). If you like we can just change that test (to use vertical-align:middle instead), which then would unblock this change (basically verbatim).

Thougths?

alanbaradlay · 2024-10-03T19:16:49Z

@karlcow @alanbaradlay - The zero table-cell + baseline isn't particularly important to the test (IMO). If you like we can just change that test (to use vertical-align:middle instead), which then would unblock this change (basically verbatim).

Thougths?

I agree that it's not super important. I could also just skip the test temporarily until after I address the baseline bug. Let's see if I can get to it in the next couple of days, if not, I'll land this one way or another.

As pointed out in: WebKit/WebKit#31376 (comment) Blink/WebKit were doing something incorrect when a baseline was outside the border-box of a flex-item. This was because we were initializing max_major_descent and max_minor_descent to zero, instead of LayoutUnit::Min(), (similar to FlexLine::max_major_ascent_ FlexLine::max_minor_ascent_). This only occurs with a single item in a flex-line. Change-Id: I4f32eb912a07247d16231451ba63e7c7a75a8b23

As pointed out in: WebKit/WebKit#31376 (comment) Blink/WebKit were doing something incorrect when a baseline was outside the border-box of a flex-item. This was because we were initializing max_major_descent and max_minor_descent to zero, instead of LayoutUnit::Min(), (similar to FlexLine::max_major_ascent_ FlexLine::max_minor_ascent_). This only occurs with a single item in a flex-line. Change-Id: I4f32eb912a07247d16231451ba63e7c7a75a8b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901280 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1363827}

karlcow · 2024-10-07T01:03:35Z

This is fixed by e0a7770

…ith extreme baselines., a=testonly Automatic update from web-platform-tests [flex] Fix line cross-size calculation with extreme baselines. As pointed out in: WebKit/WebKit#31376 (comment) Blink/WebKit were doing something incorrect when a baseline was outside the border-box of a flex-item. This was because we were initializing max_major_descent and max_minor_descent to zero, instead of LayoutUnit::Min(), (similar to FlexLine::max_major_ascent_ FlexLine::max_minor_ascent_). This only occurs with a single item in a flex-line. Change-Id: I4f32eb912a07247d16231451ba63e7c7a75a8b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901280 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1363827} -- wpt-commits: a860f3bee0f0c23461759e009149d36377c894ad wpt-pr: 48453

…ith extreme baselines., a=testonly Automatic update from web-platform-tests [flex] Fix line cross-size calculation with extreme baselines. As pointed out in: WebKit/WebKit#31376 (comment) Blink/WebKit were doing something incorrect when a baseline was outside the border-box of a flex-item. This was because we were initializing max_major_descent and max_minor_descent to zero, instead of LayoutUnit::Min(), (similar to FlexLine::max_major_ascent_ FlexLine::max_minor_ascent_). This only occurs with a single item in a flex-line. Change-Id: I4f32eb912a07247d16231451ba63e7c7a75a8b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5901280 Commit-Queue: Ian Kilpatrick <ikilpatrickchromium.org> Reviewed-by: David Grogan <dgroganchromium.org> Cr-Commit-Position: refs/heads/main{#1363827} -- wpt-commits: a860f3bee0f0c23461759e009149d36377c894ad wpt-pr: 48453 UltraBlame original commit: b4bd4104b815edf9525ea3f33cfd841a7149942a

karlcow self-assigned this Jul 29, 2024

karlcow added the CSS Cascading Style Sheets implementation label Jul 29, 2024

karlcow mentioned this pull request Jul 29, 2024

container-type does not force layout containment, but does force an independent formatting context #31264

Closed

karlcow requested a review from nt1m July 29, 2024 06:23

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 29, 2024

nt1m removed the merging-blocked Applied to prevent a change from being merged label Jul 29, 2024

nt1m changed the title ~~container-type does not force layout containment, but does force an independent formatting context~~ [container-queries] Stop forcing layout containment but force an independent formatting context Jul 29, 2024

nt1m force-pushed the eng/container-type-does-not-force-layout-containment-but-does-force-an-independent-formatting-context branch from a361626 to a694dd8 Compare July 29, 2024 08:00

nt1m self-assigned this Jul 29, 2024

nt1m force-pushed the eng/container-type-does-not-force-layout-containment-but-does-force-an-independent-formatting-context branch from a694dd8 to 5202a1e Compare July 29, 2024 08:02

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 29, 2024

karlcow removed the merging-blocked Applied to prevent a change from being merged label Jul 30, 2024

karlcow changed the title ~~[container-queries] Stop forcing layout containment but force an independent formatting context~~ [ Jul 30, 2024

karlcow force-pushed the eng/container-type-does-not-force-layout-containment-but-does-force-an-independent-formatting-context branch from 5202a1e to 3204996 Compare July 30, 2024 08:04

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 30, 2024

karlcow changed the title [ [container-queries] Stop forcing layout containment but force an independent formatting context Jul 30, 2024

karlcow requested review from donny-dont, zdobersek, a team, philn, alexgcastro, carlosgcampos, nikolaszimmermann and magomez as code owners July 30, 2024 09:53

karlcow removed the request for review from nikolaszimmermann July 30, 2024 09:54

karlcow removed the merging-blocked Applied to prevent a change from being merged label Jul 30, 2024

karlcow force-pushed the eng/container-type-does-not-force-layout-containment-but-does-force-an-independent-formatting-context branch from d10b0b7 to 66f5a44 Compare July 30, 2024 10:01

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 30, 2024

karlcow commented Jul 30, 2024

View reviewed changes

Source/WebCore/rendering/RenderTable.cpp Outdated Show resolved Hide resolved

karlcow removed the merging-blocked Applied to prevent a change from being merged label Jul 31, 2024

karlcow force-pushed the eng/container-type-does-not-force-layout-containment-but-does-force-an-independent-formatting-context branch from 66f5a44 to 9c47b8d Compare July 31, 2024 02:53

nt1m reviewed Jul 31, 2024

View reviewed changes

Source/WebCore/rendering/RenderBlock.cpp Show resolved Hide resolved

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 31, 2024

chromium-wpt-export-bot mentioned this pull request Oct 3, 2024

[flex] Fix line cross-size calculation with extreme baselines. web-platform-tests/wpt#48453

Merged

nt1m closed this Oct 4, 2024

karlcow deleted the eng/container-type-does-not-force-layout-containment-but-does-force-an-independent-formatting-context branch October 7, 2024 01:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[container-queries] Stop forcing layout containment but force an independent formatting context #31376

[container-queries] Stop forcing layout containment but force an independent formatting context #31376

karlcow commented Jul 29, 2024 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Jul 29, 2024 •

edited

Loading

karlcow commented Jul 29, 2024

nt1m commented Jul 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jul 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jul 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jul 30, 2024 •

edited

Loading

karlcow commented Jul 30, 2024

webkit-early-warning-system commented Jul 30, 2024 •

edited

Loading

karlcow commented Jul 30, 2024

webkit-early-warning-system commented Jul 31, 2024 •

edited

Loading

bfgeek commented Sep 27, 2024

karlcow commented Oct 1, 2024

bfgeek commented Oct 3, 2024

alanbaradlay commented Oct 3, 2024

karlcow commented Oct 7, 2024

[container-queries] Stop forcing layout containment but force an independent formatting context #31376

[container-queries] Stop forcing layout containment but force an independent formatting context #31376

Conversation

karlcow commented Jul 29, 2024 • edited by webkit-early-warning-system Loading

9c47b8d

webkit-early-warning-system commented Jul 29, 2024 • edited Loading

karlcow commented Jul 29, 2024

nt1m commented Jul 29, 2024 • edited Loading

webkit-early-warning-system commented Jul 29, 2024 • edited Loading

webkit-early-warning-system commented Jul 29, 2024 • edited Loading

webkit-early-warning-system commented Jul 30, 2024 • edited Loading

karlcow commented Jul 30, 2024

webkit-early-warning-system commented Jul 30, 2024 • edited Loading

karlcow commented Jul 30, 2024

webkit-early-warning-system commented Jul 31, 2024 • edited Loading

bfgeek commented Sep 27, 2024

karlcow commented Oct 1, 2024

bfgeek commented Oct 3, 2024

alanbaradlay commented Oct 3, 2024

karlcow commented Oct 7, 2024

karlcow commented Jul 29, 2024 •

edited by webkit-early-warning-system

Loading

`9c47b8d`

webkit-early-warning-system commented Jul 29, 2024 •

edited

Loading

nt1m commented Jul 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jul 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jul 29, 2024 •

edited

Loading

webkit-early-warning-system commented Jul 30, 2024 •

edited

Loading

webkit-early-warning-system commented Jul 30, 2024 •

edited

Loading

webkit-early-warning-system commented Jul 31, 2024 •

edited

Loading