Use X86_64 and C_LOOP OFFLINE_ASM_BACKEND on Windows#31788
Merged
webkit-commit-queue merged 1 commit intoAug 6, 2024
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 6ba1273) Details |
6ba1273 to
114635e
Compare
Collaborator
|
EWS run on current version of this PR (hash 114635e) Details |
https://bugs.webkit.org/show_bug.cgi?id=277631 Reviewed by Yusuke Suzuki. By using the X86_64 and C_LOOP backends on Windows and getting rid of X86_64_WIN and C_LOOP_WIN, it helps prevent regressions caused by forgetting to add "or X86_64_WIN" and "or C_LOOP_WIN" everywhere. * Source/JavaScriptCore/CMakeLists.txt: * Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h: * Source/JavaScriptCore/llint/LowLevelInterpreter.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter64.asm: * Source/JavaScriptCore/llint/WebAssembly.asm: * Source/JavaScriptCore/llint/WebAssembly64.asm: * Source/JavaScriptCore/offlineasm/asm.rb: * Source/JavaScriptCore/offlineasm/backends.rb: * Source/JavaScriptCore/offlineasm/cloop.rb: * Source/JavaScriptCore/offlineasm/x86.rb: * Source/JavaScriptCore/wasm/js/JSToWasm.cpp: (JSC::Wasm::createJSToWasmJITInterpreter): Canonical link: https://commits.webkit.org/281909@main
114635e to
4ea9490
Compare
Collaborator
|
Committed 281909@main (4ea9490): https://commits.webkit.org/281909@main Reviewed commits have been landed. Closing PR #31788 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4ea9490
114635e
🛠 🧪 jsc-arm64🧪 gtk-wk2