-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use X86_64 and C_LOOP OFFLINE_ASM_BACKEND on Windows #31788
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
iangrunert:ig/unify-windows-offlineasm-backends
Aug 6, 2024
Merged
Use X86_64 and C_LOOP OFFLINE_ASM_BACKEND on Windows #31788
webkit-commit-queue
merged 1 commit into
WebKit:main
from
iangrunert:ig/unify-windows-offlineasm-backends
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 6ba1273) |
Constellation
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
iangrunert
force-pushed
the
ig/unify-windows-offlineasm-backends
branch
from
August 6, 2024 17:15
6ba1273
to
114635e
Compare
EWS run on current version of this PR (hash 114635e) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Aug 6, 2024
Constellation
added
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
and removed
merging-blocked
Applied to prevent a change from being merged
labels
Aug 6, 2024
https://bugs.webkit.org/show_bug.cgi?id=277631 Reviewed by Yusuke Suzuki. By using the X86_64 and C_LOOP backends on Windows and getting rid of X86_64_WIN and C_LOOP_WIN, it helps prevent regressions caused by forgetting to add "or X86_64_WIN" and "or C_LOOP_WIN" everywhere. * Source/JavaScriptCore/CMakeLists.txt: * Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h: * Source/JavaScriptCore/llint/LowLevelInterpreter.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm: * Source/JavaScriptCore/llint/LowLevelInterpreter64.asm: * Source/JavaScriptCore/llint/WebAssembly.asm: * Source/JavaScriptCore/llint/WebAssembly64.asm: * Source/JavaScriptCore/offlineasm/asm.rb: * Source/JavaScriptCore/offlineasm/backends.rb: * Source/JavaScriptCore/offlineasm/cloop.rb: * Source/JavaScriptCore/offlineasm/x86.rb: * Source/JavaScriptCore/wasm/js/JSToWasm.cpp: (JSC::Wasm::createJSToWasmJITInterpreter): Canonical link: https://commits.webkit.org/281909@main
webkit-commit-queue
force-pushed
the
ig/unify-windows-offlineasm-backends
branch
from
August 6, 2024 20:24
114635e
to
4ea9490
Compare
Committed 281909@main (4ea9490): https://commits.webkit.org/281909@main Reviewed commits have been landed. Closing PR #31788 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4ea9490
114635e
🛠 🧪 jsc-arm64🧪 gtk-wk2