Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use X86_64 and C_LOOP OFFLINE_ASM_BACKEND on Windows #31788

Conversation

iangrunert
Copy link
Contributor

@iangrunert iangrunert commented Aug 6, 2024

4ea9490

Use X86_64 and C_LOOP OFFLINE_ASM_BACKEND on Windows
https://bugs.webkit.org/show_bug.cgi?id=277631

Reviewed by Yusuke Suzuki.

By using the X86_64 and C_LOOP backends on Windows and getting rid of
X86_64_WIN and C_LOOP_WIN, it helps prevent regressions caused by
forgetting to add "or X86_64_WIN" and "or C_LOOP_WIN" everywhere.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h:
* Source/JavaScriptCore/llint/LowLevelInterpreter.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:
* Source/JavaScriptCore/llint/WebAssembly.asm:
* Source/JavaScriptCore/llint/WebAssembly64.asm:
* Source/JavaScriptCore/offlineasm/asm.rb:
* Source/JavaScriptCore/offlineasm/backends.rb:
* Source/JavaScriptCore/offlineasm/cloop.rb:
* Source/JavaScriptCore/offlineasm/x86.rb:
* Source/JavaScriptCore/wasm/js/JSToWasm.cpp:
(JSC::Wasm::createJSToWasmJITInterpreter):

Canonical link: https://commits.webkit.org/281909@main

114635e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@iangrunert iangrunert requested a review from a team as a code owner August 6, 2024 17:02
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@iangrunert iangrunert force-pushed the ig/unify-windows-offlineasm-backends branch from 6ba1273 to 114635e Compare August 6, 2024 17:15
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Aug 6, 2024
@Constellation Constellation added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Aug 6, 2024
https://bugs.webkit.org/show_bug.cgi?id=277631

Reviewed by Yusuke Suzuki.

By using the X86_64 and C_LOOP backends on Windows and getting rid of
X86_64_WIN and C_LOOP_WIN, it helps prevent regressions caused by
forgetting to add "or X86_64_WIN" and "or C_LOOP_WIN" everywhere.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/llint/LLIntOfflineAsmConfig.h:
* Source/JavaScriptCore/llint/LowLevelInterpreter.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:
* Source/JavaScriptCore/llint/WebAssembly.asm:
* Source/JavaScriptCore/llint/WebAssembly64.asm:
* Source/JavaScriptCore/offlineasm/asm.rb:
* Source/JavaScriptCore/offlineasm/backends.rb:
* Source/JavaScriptCore/offlineasm/cloop.rb:
* Source/JavaScriptCore/offlineasm/x86.rb:
* Source/JavaScriptCore/wasm/js/JSToWasm.cpp:
(JSC::Wasm::createJSToWasmJITInterpreter):

Canonical link: https://commits.webkit.org/281909@main
@webkit-commit-queue webkit-commit-queue force-pushed the ig/unify-windows-offlineasm-backends branch from 114635e to 4ea9490 Compare August 6, 2024 20:24
@webkit-commit-queue
Copy link
Collaborator

Committed 281909@main (4ea9490): https://commits.webkit.org/281909@main

Reviewed commits have been landed. Closing PR #31788 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4ea9490 into WebKit:main Aug 6, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants