[Gstreamer][HLS] Unable to play TED videos #8100
Conversation
|
EWS run on previous version of this PR (hash 482bc41)
|
|
In case it helps, this looks good to me (but I'm not a reviewer). The idea of the environment variable is great, because we might still need native HLS support downstream in the short/mid term. |
|
EWS run on previous version of this PR (hash c245e09)
|
| @@ -416,6 +415,12 @@ void GStreamerRegistryScanner::initializeDecoders(const GStreamerRegistryScanner | |||
| { ElementFactories::Type::Demuxer, "video/quicktime, variant=(string)3gpp", { "video/3gpp"_s }, { } }, | |||
| { ElementFactories::Type::Demuxer, "video/x-ms-asf", { }, { } }, | |||
| }; | |||
|
|
|||
| if (const char* hlsSupport = getenv("WEBKIT_GST_ENABLE_HLS_SUPPORT")) { | |||
| if (!strcmp(hlsSupport, "1")) | |||
There was a problem hiding this comment.
Please, use g_getenv and g_strcmp0 instead.
There was a problem hiding this comment.
Sorry I don't remember about g_getenv, is this some policy? Because we have a mix of getenv and g_getenv currently. About g_strcmp0 well we're already guaranteed here that hlsSupport is not NULL, so I'm not sure there's a point :)
There was a problem hiding this comment.
I think both are safer and more platform compatible, specially if code changes and for some reason strcmp is not protected by the if above.
|
EWS run on current version of this PR (hash c231120)
|
webkit-commit-queue
force-pushed
the
eng/174458
branch
from
c231120
to
3858939
Compare
https://bugs.webkit.org/show_bug.cgi?id=174458 Reviewed by Xabier Rodriguez-Calvar. Disable HLS support by default in GStreamer ports. The underlying GStreamer hlsdemux element is not receiving much maintenance and its replacement, hlsdemux2, cannot be used by WebKit due to sandboxing requirements. Most websites should now fallback to MSE if HLS is not supported by the User-Agent. This was checked on TED and Apple developer websites. HLS support can be re-enabled at runtime by setting the `WEBKIT_GST_ENABLE_HLS_SUPPORT=1` environment variable. * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::initializeDecoders): Canonical link: https://commits.webkit.org/258717@main
webkit-commit-queue
force-pushed
the
eng/174458
branch
from
3858939
to
e2afda4
Compare
|
Committed 258717@main (e2afda4): https://commits.webkit.org/258717@main Reviewed commits have been landed. Closing PR #8100 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
e2afda4
c231120
🛠 🧪 win🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-AS-debug-wk2