-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[ATSPI] Modal element containing only StaticText is ignored #5230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
obyknovenius:aria-modal-static-text
Dec 1, 2022
Merged
[ATSPI] Modal element containing only StaticText is ignored #5230
webkit-commit-queue
merged 1 commit into
WebKit:main
from
obyknovenius:aria-modal-static-text
Dec 1, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EWS run on previous version of this PR (hash 00bdd61)
|
carlosgcampos
approved these changes
Oct 11, 2022
00bdd61
to
3678d8e
Compare
EWS run on previous version of this PR (hash 3678d8e)
|
3678d8e
to
ab452d3
Compare
EWS run on current version of this PR (hash ab452d3) |
https://bugs.webkit.org/show_bug.cgi?id=246329 Reviewed by Carlos Garcia Campos. A modal element will not be set as the current modal when it has no accessible content. But when using AT-SPI, an object with AccessibilityRole::StaticText is ignored, since we expect its parent to implement org.a11y.atspi.Text interface itself. Fixes `accessibility/custom-elements/modal.html` time out. * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::modalElementHasAccessibleContent): Canonical link: https://commits.webkit.org/257235@main
ab452d3
to
99e0cc3
Compare
Committed 257235@main (99e0cc3): https://commits.webkit.org/257235@main Reviewed commits have been landed. Closing PR #5230 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
99e0cc3
ab452d3