Skip to content

Conversation

obyknovenius
Copy link
Contributor

@obyknovenius obyknovenius commented Oct 11, 2022

99e0cc3

[ATSPI] Modal element containing only StaticText is ignored
https://bugs.webkit.org/show_bug.cgi?id=246329

Reviewed by Carlos Garcia Campos.

A modal element will not be set as the current modal when it has no
accessible content. But when using AT-SPI, an object with
AccessibilityRole::StaticText is ignored, since we expect its parent
to implement org.a11y.atspi.Text interface itself.

Fixes `accessibility/custom-elements/modal.html` time out.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::modalElementHasAccessibleContent):

Canonical link: https://commits.webkit.org/257235@main

ab452d3

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@obyknovenius obyknovenius force-pushed the aria-modal-static-text branch from 00bdd61 to 3678d8e Compare October 11, 2022 13:39
@obyknovenius obyknovenius force-pushed the aria-modal-static-text branch from 3678d8e to ab452d3 Compare October 11, 2022 14:32
@obyknovenius obyknovenius added the request-merge-queue Request a pull request to be added to merge-queue once ready label Nov 7, 2022
@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label Dec 1, 2022
https://bugs.webkit.org/show_bug.cgi?id=246329

Reviewed by Carlos Garcia Campos.

A modal element will not be set as the current modal when it has no
accessible content. But when using AT-SPI, an object with
AccessibilityRole::StaticText is ignored, since we expect its parent
to implement org.a11y.atspi.Text interface itself.

Fixes `accessibility/custom-elements/modal.html` time out.

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::modalElementHasAccessibleContent):

Canonical link: https://commits.webkit.org/257235@main
@webkit-commit-queue
Copy link
Collaborator

Committed 257235@main (99e0cc3): https://commits.webkit.org/257235@main

Reviewed commits have been landed. Closing PR #5230 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed merge-queue Applied to send a pull request to merge-queue request-merge-queue Request a pull request to be added to merge-queue once ready labels Dec 1, 2022
@webkit-commit-queue webkit-commit-queue merged commit 99e0cc3 into WebKit:main Dec 1, 2022
@obyknovenius obyknovenius deleted the aria-modal-static-text branch February 29, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants