Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies #170

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

kentbull
Copy link
Contributor

Rationale

Upgrading to the most recent dependencies worked and resolved a build failure on the outdated check with cargo outdated -R --exit-code 1 in the Makefile.

Testing

All tests passed. There is no new functionality so a passing build is enough to merge.

For Reviewers

  • [X ] Verify version bumped in Cargo.toml -> version 0.6.5

@kentbull kentbull changed the title Update dependencies chore: Update dependencies Jun 26, 2024
Copy link
Collaborator

@daidoji daidoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @jasoncolburne consumes this directly though so he'll have to sign off to make sure things aren't breaking but updating dependencies is probably a good idea.

@jasoncolburne
Copy link
Collaborator

Updates to deps are always welcome. We can fix whatever breaks if anything does, but the tests should tell us.

@jasoncolburne
Copy link
Collaborator

Thanks for this, Kent!

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.43%. Comparing base (f35b795) to head (2f286a8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   95.42%   95.43%   +0.01%     
==========================================
  Files          32       32              
  Lines        3037     3045       +8     
==========================================
+ Hits         2898     2906       +8     
  Misses        139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daidoji daidoji merged commit 756a402 into WebOfTrust:main Jun 27, 2024
3 checks passed
@kentbull kentbull deleted the kb/deps-update branch June 27, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants