[GTK][WPE] PlatformDisplay::terminateEglDisplays() is never called #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.webkit.org/show_bug.cgi?id=217655 Stop the run loop for GTK and WPE to ensure a normal exit, since we need atexit handlers to be called to cleanup resources like EGL displays. Reviewed by Carlos Garcia Campos. * Shared/AuxiliaryProcess.cpp: (WebKit::AuxiliaryProcess::didClose): * WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeConnection): * WebProcess/WebProcess.h: * WebProcess/glib/WebProcessGLib.cpp: (WebKit::WebProcess::stopRunLoop): Canonical link: https://commits.webkit.org/247678@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
|
This change introduced a regression in upstream (https://bugs.webkit.org/show_bug.cgi?id=238494) but the regression was related to GTK and seems to be safe for WPE. I discussed it with cgarcia. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.webkit.org/show_bug.cgi?id=217655
Stop the run loop for GTK and WPE to ensure a normal exit, since we need atexit handlers to be called to cleanup resources like EGL displays.
Reviewed by Carlos Garcia Campos.
Canonical link: https://commits.webkit.org/247678@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290360 268f45cc-cd09-0410-ab3c-d52691b4dbfc