Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Sdk for PHP v3 support #105

Merged
merged 2 commits into from
Jul 7, 2016
Merged

AWS Sdk for PHP v3 support #105

merged 2 commits into from
Jul 7, 2016

Conversation

jackdpeterson
Copy link
Contributor

Resolves #90 and #103

@jackdpeterson
AWS SDK For PHP v3 support.
a7c8c19 
Anticipating a 2.0 release due to potentical BC breaks with PHP language.
Minimum PHP required version bumped to PHP 5.6 as this is the 'actively supported' release of PHP.
Resolves Webador#90 and Webador#103
@jackdpeterson
update changelog
bebe45c
@jackdpeterson jackdpeterson mentioned this pull request Jul 7, 2016
Closed
@jackdpeterson
Copy link
Contributor Author

A few things to note:

  1. This resolves some warnings from phpunit about the getMock versus createMock (the suggested way).
  2. I'm assuming that this will be a 2.0.0 tagged bump due to BC breakage.
  3. I'm assuming that setting the minimum to PHP 5.6 is perfectly acceptable because even phpunit complains about 5.5. Furthermore, major distributions of linux are now including php 7 at this juncture and providing legacy support for security-only versions of PHP is sub-optimal from a forward-looking perspective.

@jackdpeterson
Copy link
Contributor Author

ping @bakura10 on merging this in

@bakura10
Copy link
Contributor

bakura10 commented Jul 7, 2016

Looks pretty nice to me!

@bakura10 bakura10 merged commit e63377c into Webador:master Jul 7, 2016
@bakura10 bakura10 mentioned this pull request Jul 7, 2016
Closed
@bakura10
Copy link
Contributor

bakura10 commented Jul 7, 2016

Tagged as 2.0.0.

Thanks!

@jackdpeterson
Copy link
Contributor Author

Thanks for the quick merge :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackdpeterson @bakura10