Update SendGridService.php #70
Conversation
SendGrid should not attach a filetype
|
Although SendGrid recommends to send the filetype, there are also some examples where they do not. I can assume we can merge this fix then... @juriansluiman thoughts? |
|
I will test today and merge. I guess if you want to set the file type explicitly, we have to come up with another solution. |
Update SendGridService.php
|
With the file type addition (old master) Sendgrid did work for me too, but I guess you are right Google is smart enough to remove the last bits and Outlook is a typical client which struggles with such addition. Removing the type did not cause any problems with my GMail client :) |
|
By the way, 1.4.1 is tagged now with this change! |
|
I wonder if SendGrid is unable to pick up the file type for binary files versus more basic files types? I might look into why this was failing to offer a healthier approach then tear it out. When it is tagged for 1.4.1, does that mean it will be in composer the next deploy? |
|
I have tested it with .pdf and .txt files. There has to be a way to enforce the file type, but I now prefer to add this and ensure it works in Outlook too. Just to confirm: the problem only exists in Outlook? I can only test in GMail (web/phone) and I have no other client available.... |
|
Incorrect. The problem is in the file data itself. Excel is smart enough to detect that it is a string appended onto the end of the file and offer a prompt to fix it. Outlook does not do such a thing for excel files. I opened my excel file as a binary and could see the physical text string tacked onto the end of the binary. |
SendGrid should not attach a filetype
This is causing serious issues and serves no purpose. Remove the bug from the library! I use SendGrid and can tell you that it won't work. Most file readers are smart enough to detect a corrupted textual addition to the file, but then preview mode is disabled in Outlook.