Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to Label and put a toolip #11907

Merged

Conversation

harriebird
Copy link
Collaborator

Proposed changes

Added description field to the Label model and set it as a tooltip.
This solves issue #9227.

Example images:

Screenshot from 2024-06-21 00-21-20

Screenshot 2024-06-21 at 00-34-36 Test Project @ Devel Weblate

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@harriebird harriebird force-pushed the feature/add-description-and-tooltip-on-labels branch from fa8a71e to aa71e76 Compare June 20, 2024 16:57
@nijel nijel added this to the 5.7 milestone Jun 24, 2024
@nijel nijel linked an issue Jun 24, 2024 that may be closed by this pull request
@nijel nijel self-assigned this Jun 24, 2024
@nijel
Copy link
Member

nijel commented Jun 24, 2024

  • Seems like the tests were not updated to new field.
  • LabelSerializer for the API needs update as well.

@harriebird harriebird force-pushed the feature/add-description-and-tooltip-on-labels branch from aa71e76 to dbe333c Compare June 24, 2024 16:03
@harriebird
Copy link
Collaborator Author

Updated the tests and added description in the LabelSerializer fields.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.61%. Comparing base (6aee586) to head (dbe333c).
Report is 4380 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11907      +/-   ##
==========================================
- Coverage   90.82%   90.61%   -0.21%     
==========================================
  Files         554      578      +24     
  Lines       57306    58835    +1529     
  Branches     9122     9393     +271     
==========================================
+ Hits        52046    53313    +1267     
- Misses       3640     3829     +189     
- Partials     1620     1693      +73     
Files with missing lines Coverage Δ
weblate/api/serializers.py 92.57% <100.00%> (+0.10%) ⬆️
weblate/api/tests.py 100.00% <100.00%> (ø)
weblate/trans/forms.py 88.55% <100.00%> (+0.68%) ⬆️
weblate/trans/migrations/0019_label_description.py 100.00% <100.00%> (ø)
weblate/trans/models/label.py 100.00% <100.00%> (ø)
weblate/trans/tests/test_labels.py 100.00% <100.00%> (ø)

... and 329 files with indirect coverage changes

@nijel nijel merged commit 8abef5e into WeblateOrg:main Jun 25, 2024
31 checks passed
@nijel
Copy link
Member

nijel commented Jun 25, 2024

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label description and tooltip
2 participants