Show string/word numbers on search results #11910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijel
reviewed
Jun 21, 2024
weblate/trans/views/search.py
Outdated
|
|
||
| # Calculate total number of strings and words | ||
| total_strings = units.paginator.count | ||
| total_words = sum(unit.num_words for unit in units.object_list) |
There was a problem hiding this comment.
The strings number is for all strings, but words number just for the current page.
weblate/templates/search.html
Outdated
| @@ -19,6 +19,7 @@ | |||
| {% crispy search_form %} | |||
| </form> | |||
| {% if page_obj.object_list %} | |||
| <div><p>{{ total_strings }} strings / {{ total_words }} words</p></div> | |||
updated total_words for all words instead of words for current page.
JagdishAneshwar
commented
Jun 21, 2024
nijel
reviewed
Jun 25, 2024
| @@ -157,7 +157,7 @@ def search(request, path=None): | |||
|
|
|||
| # Calculate total number of strings and words | |||
| total_strings = units.paginator.count | |||
| total_words = sum(unit.num_words for unit in units.object_list) | |||
| total_words = sum(unit.num_words for unit in unit_set.all()) | |||
There was a problem hiding this comment.
This will be super slow on huge results, this needs a database aggregation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request adds the display of total strings and words in search results. Issue: #11853
Changes Introduced: