Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reformer as an imputation model #433

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Add Reformer as an imputation model #433

merged 2 commits into from
Jun 18, 2024

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Add Reformer #414;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu WenjieDu merged commit ba116eb into dev Jun 18, 2024
4 of 8 checks passed
@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9560069088

Details

  • 411 of 660 (62.27%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.2%) to 82.838%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/reformer/model.py 69 72 95.83%
pypots/nn/modules/reformer/local_attention.py 43 165 26.06%
pypots/nn/modules/reformer/lsh_attention.py 226 350 64.57%
Files with Coverage Reduction New Missed Lines %
pypots/classification/base.py 1 72.97%
pypots/clustering/vader/model.py 1 84.42%
Totals Coverage Status
Change from base Build 9550667264: -1.2%
Covered Lines: 10069
Relevant Lines: 12155

💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9560069088

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 411 of 660 (62.27%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.2%) to 82.838%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/reformer/model.py 69 72 95.83%
pypots/nn/modules/reformer/local_attention.py 43 165 26.06%
pypots/nn/modules/reformer/lsh_attention.py 226 350 64.57%
Files with Coverage Reduction New Missed Lines %
pypots/classification/base.py 1 72.97%
pypots/clustering/vader/model.py 1 84.42%
Totals Coverage Status
Change from base Build 9550667264: -1.2%
Covered Lines: 10069
Relevant Lines: 12155

💛 - Coveralls

@WenjieDu WenjieDu deleted the (feat)add_reformer branch June 18, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants