-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: explicit channels in conda env ymls #7
Conversation
Define channels from which to get the packages; This could decrease solving time; Remove default channel - everything in conda-forge is better anyway.
Be explicit about channels in conda env yml files. Use conda package instead of pip whenever possible.
torchdiffeq on PyPI is in 0.2.3 and on conda-forge 0.2.2. This makes a huge difference!
Hi Maciej, Yes, I noticed that building an environment for PyPOTS does take some time. So your PR looks helpful indeed. Thank you for your idea! But GitHub auto-testing met errors with your PR. Please check it out here. |
Yeah, I noticed that so i closed the PR and am working on fixing it :) |
Cool. Please reopen your PR when you think it's ready. Then we can run a test to see if your commits can speed up the process of environment building. |
If the tests pass, we could probably speed it up a lot by determining possible version range per package, but I guess that would make us conda dependency resolvers 😉 |
This commit works fine. You can try to specify the version of each package to see how much it can speed up. 👀 |
Freeze all explicitly mentioned packages to test max potential installation time gain from determining version range of each dependency
I froze the test env, each package with one version explicitly set. If the time gain is not huge I don't think it is worth testing each dependency and searching for minimal requirements. |
This reverts commit 0fec3c9.
The tests failed, i capitulate 😭 🏳️ |
i tried creating environment_test.yml with python3.7.13 in mind; let's see if the tests pass this time.
last try with versions that conda found for me with python3.7.13 |
No worries. I'll give your idea a try by myself when I have time 😃. I add this idea in GitHub Discussion, you can check it out here #8 |
I'm closing this PR due to the problem has been solved in the latest release |
Hi! You may have noticed that, when creating a new conda environment from *.yml file, it takes ages to solve package dependencies.
I attempt to speed the process up by explicitly defining channel in which to search for a package. I also defined minimal pandas version to be
1.4.1
- the things were weird before that. I also allow for python versions newer than3.7.13
and I believe you'll find it acceptable.Please let me know if this is in any way helpful.