Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of various view drawing code #1698

Merged
merged 4 commits into from
Jun 8, 2024
Merged

Conversation

jumanji144
Copy link
Collaborator

@jumanji144 jumanji144 commented May 22, 2024

Refactored:

  • ViewDatainspector
  • ViewAbout

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 377 lines in your changes are missing coverage. Please review.

Project coverage is 1.51%. Comparing base (bdaf1e4) to head (4a71b7f).
Report is 3 commits behind head on master.

Files Patch % Lines
...iltin/source/content/views/view_data_inspector.cpp 0.00% 217 Missing ⚠️
...lugins/builtin/source/content/views/view_about.cpp 0.00% 160 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1698      +/-   ##
=========================================
- Coverage    1.51%   1.51%   -0.01%     
=========================================
  Files         275     275              
  Lines       27008   27069      +61     
  Branches    14474   14478       +4     
=========================================
  Hits          409     409              
- Misses      26341   26402      +61     
  Partials      258     258              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jumanji144 jumanji144 changed the title Refactor view data inspector setup and drawing code Refactor of various view drawing code May 23, 2024
@WerWolv WerWolv merged commit 41b2523 into WerWolv:master Jun 8, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants