Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for self-signed SSL certificates #27

Merged
merged 2 commits into from
Dec 15, 2020
Merged

Add support for self-signed SSL certificates #27

merged 2 commits into from
Dec 15, 2020

Conversation

LauLaman
Copy link
Collaborator

  • Add support for self sigend certificates to KvkClientFactory
  • Add dutch government root certificate
  • Update tests

fixes #26

@thijsBreker
Copy link
Collaborator

I'm missing a test for the deprecated use-case. Other than that it looks good to me 👍

@LauLaman
Copy link
Collaborator Author

LauLaman commented Sep 30, 2020 •
edited
Loading

@thijsBreker E_USER_DEPRECATED is written directly to the stdout so not easily testable.

The way I can think of is setting error_reporting(E_ERROR); and run a test. So we only test that the code still works when no certificate is given, and are not testing that the user deprecation warning is given.

Unless you know a way to test this?

@LauLaman
Add support for self-signed SSL certificates
d987791 
- Add support for self sigend certificates to KvkClientFactory
- Add dutch government root certificate
- Update tests
@LauLaman
Copy link
Collaborator Author

LauLaman commented Nov 4, 2020

Can we merge this? A Tests is in place to make sure backward compatibility is still working. The only thing that's super hard to test is the stdout error message.

thijsBreker
thijsBreker approved these changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@thijsBreker thijsBreker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's merge this 👍

@LauLaman
Copy link
Collaborator Author

LauLaman commented Nov 18, 2020 •
edited
Loading

@thijsBreker Looks like the automatic tests (like Scrutinizer) are stuck..

@LauLaman
Copy link
Collaborator Author

@thijsBreker 🛎

@MarijnKoesen
Copy link

Thanks @LauLaman ! We're looking into the scrutinizer issues, we're hoping to get it merged tomorrow :)

@MarijnKoesen MarijnKoesen merged commit c2973d6 into Werkspot:master Dec 15, 2020
@Duncank
Copy link

Duncank commented Dec 15, 2020

@MarijnKoesen Thanks for merging! Will you create a new release as well so we can update this plugin?

@LauLaman
Copy link
Collaborator Author

@Duncank the new release is v0.1.3

@LauLaman LauLaman mentioned this pull request May 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijsBreker thijsBreker thijsBreker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New certificate chain causing issues
4 participants
@LauLaman @thijsBreker @MarijnKoesen @Duncank