Experimental fixes #145
Merged
Experimental fixes #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere were other issues in how the templating, and remote resourcing was being handled that this commit fixes. Updated template directory for the pyvis package to import the template directory as a jinja template environment instead of by file. Previous was imported by filename and didn't allow for include statements as well as not being a template directory. Sources were added without integrety hashes. Updated to import using said integrity checks. Added new argument to Network declration to change how resources are packaged into the end product. This adds remote, in_line, and local as options for building the template. In-line takes raw js files from the lib directory and injects them as inline javascript and can be used for local non-internet access situations, as well when remote files don't wish to be trusted. Remote pulls said sources from remote with integrety checks handled. local will pull the resources from the local lib directory as was being performed before. in_line and remote fixes an issue with pyvis in jupyter-notebook on chrome and safari that caused graphics to error with a blank object due to jupyter denying access due to a CORBS policy due to chrome and safari removing referer on requests to same origin cdns. <meta charset='utf-8'> is a fix for the tom-select pacakge as there is non utf-8 characters implimented. Wrapped tom_select template initialization to check if select_menu is ture as they were being initialized and thus causing errors when this option was set to false. Updated jupyter-notebook to contain options, and examples of the node selection to be able to test changes.
|
Checked through pull request created by @EgorPichkur at direction of @jhunpingco. Worked through bugs that arose due to the inclusion of tom-select as well as updating the templating structure to use the jinja template environment. (This change shouldn't be non-breaking, but might want to look into the provided template options to make sure they don't break.) This update also provides options for different remote resources [in_line, remote, local] that provides options for different deployments as well as fixes a bug between chrome and jupyter-notebook with removing the referer from file requests (set in_line or remote allows graphics in jupyter-notebook on chrome. Previous fix was to use a different browser.) |
… directory is generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 fixes and 1 possible feature:
Thanks to @AlexanderGolub for the help with the point 2