Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impv: Get database name from jdbc url #66

Merged
merged 1 commit into from
Feb 28, 2023
Merged

impv: Get database name from jdbc url #66

merged 1 commit into from
Feb 28, 2023

Conversation

zhongjiajie
Copy link
Contributor

  • Get database name from jdbc url instead of database field
  • Try to get url when using seatunnel datasource connector

* Get database name from jdbc url instead of database field
* Try to get url when using seatunnel datasource connector
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (031b11b) 68.54% compared to head (6dccd6a) 68.54%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   68.54%   68.54%           
=======================================
  Files          15       15           
  Lines         604      604           
=======================================
  Hits          414      414           
  Misses        190      190           
Flag Coverage Δ
unittests 68.54% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/air2phin/fake/core/hook.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhongjiajie zhongjiajie merged commit d8c4b8f into main Feb 28, 2023
@zhongjiajie zhongjiajie deleted the fetch-db-url branch February 28, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants