Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fake hook support parameter conn_id and fetch result #78

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

zhongjiajie
Copy link
Contributor

support pass parameter conn_id to base hook, and fetch correct the result fetch from parameter

* fix scalar_return_last error
* add log
@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.97 ⚠️

Comparison is base (3f8871b) 60.81% compared to head (58c631d) 59.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   60.81%   59.85%   -0.97%     
==========================================
  Files          18       18              
  Lines         684      695      +11     
==========================================
  Hits          416      416              
- Misses        268      279      +11     
Flag Coverage Δ
unittests 59.85% <0.00%> (-0.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/air2phin/fake/core/hook.py 0.00% <0.00%> (ø)
src/air2phin/fake/hooks/mysql.py 0.00% <0.00%> (ø)
src/air2phin/fake/hooks/postgres.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhongjiajie zhongjiajie merged commit a308cb5 into main Mar 16, 2023
@zhongjiajie zhongjiajie deleted the hook-impv branch March 16, 2023 09:27
zhongjiajie added a commit that referenced this pull request Jul 18, 2023
* fix scalar_return_last error
* add log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants