-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add references to Elvis/Linter rules. #91
Conversation
Using `rebar3_lint` / `elvis`, you can automate most of the "manual" work required for linting. I think it's a good idea to guide folks that reach this page from the broader Erlang ecosystem to a tool that can help them with that, just like `erlfmt` can help them with formatting. I would also like to recommend you to take a look at the [Erlang Guidelines](https://github.com/inaka/erlang_guidelines). Maybe you can contribute some updates based on what's here and we can unify the list, to provide a single comprehensive guide for newcommers.
Hi @elbrujohalcon! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thank you! |
I like the idea of trying to unify this list with the guidelines. I'll take a look and see what we could do in there. Do you think there are any major differences between the two? |
Not sure. You have some really good ones that we don't have. That's for sure. |
Using
rebar3_lint
/elvis
, you can automate most of the "manual" work required for linting.I think it's a good idea to guide folks that reach this page from the broader Erlang ecosystem to a tool that can help them with that, just like
erlfmt
can help them with formatting.I would also like to recommend you to take a look at the Erlang Guidelines. Maybe you can contribute some updates based on what's here and we can unify the list, to provide a single comprehensive guide for newcommers.