Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec/tests closer to src code #218

Open
2 of 19 tasks
hirako2000 opened this issue Mar 22, 2017 · 5 comments
Open
2 of 19 tasks

Spec/tests closer to src code #218

hirako2000 opened this issue Mar 22, 2017 · 5 comments
Assignees
@hirako2000
Labels
MAINTAINANCE

Comments

@hirako2000
Copy link
Collaborator

hirako2000 commented Mar 22, 2017 •
edited by sasha240100
Loading

Ideally the tests should be closer to the src code.

Why?
Incentive to test the code. Not having to search for where existing specs are etc.
If not possible/difficult with our current setup, let's at least bring structure to the specs we have in the test folder.

Or discuss. what we have right now is far from ideal.

Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion
Tested on:
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera
@thejmazz
Copy link
Contributor

so can use jest style? with __spec__ (or similar) folder alongside code

@sasha240100
Copy link
Member

@thejmazz We discussed. I suggest having tests in src folder like Component.spec.js. That way we can easily see which tests need to be done

@hirako2000 hirako2000 self-assigned this Mar 29, 2017
@hirako2000
Copy link
Collaborator Author

I think @thejmazz is correct.
We can bring it closer to the src, but with that test and mock pattern.

hirako2000 added a commit that referenced this issue Mar 30, 2017
@hirako2000
Moves all existing tests close to src #218
36ececa
sasha240100 added a commit that referenced this issue Apr 1, 2017
@sasha240100
Merge pull request #227 from WhitestormJS/#218
a455633 
PR to Moves all existing tests close to src #218
@hirako2000
Copy link
Collaborator Author

@sasha240100 can you check the async change I made, and merge?

@sasha240100
Copy link
Member

@hirako2000 Yes, where to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hirako2000 hirako2000

Labels
MAINTAINANCE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thejmazz @hirako2000 @sasha240100