Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ts] Property 'DefineModule' does not exist #386

Closed
2 of 19 tasks
hirako2000 opened this issue Jun 28, 2018 · 1 comment
Closed
2 of 19 tasks

[ts] Property 'DefineModule' does not exist #386

hirako2000 opened this issue Jun 28, 2018 · 1 comment
Labels
TYPES

Comments

@hirako2000
Copy link
Collaborator

Getting a ts error

 [ts] Property 'DefineModule' does not exist on type 'typeof import("node_modules/whs/types/index")'.

This module is not defined in types

Version:
  • v2.x.x
  • v1.x.x
Issue type:
  • Bug
  • Proposal/Enhancement
  • Question
  • Discussion
Tested on:
Desktop
  • Chrome
  • Chrome Canary
  • Chrome dev-channel
  • Firefox
  • Opera
  • Microsoft IE
  • Microsoft Edge
Android
  • Chrome
  • Firefox
  • Opera
IOS
  • Chrome
  • Firefox
  • Opera
hirako2000 added a commit that referenced this issue Jun 28, 2018
@hirako2000
Adds DefineModule type, fixes a few check style issues #386
eeaa709
hirako2000 added a commit that referenced this issue Jun 28, 2018
@hirako2000
Removes incorrect function #386
1ce4bfd
@shaochun
Copy link
Contributor

Thanks for the quick fix!

hirako2000 added a commit that referenced this issue Jun 28, 2018
@hirako2000
Merge pull request #387 from WhitestormJS/#386
1c2f8e2 
PR for #386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TYPES
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hirako2000 @shaochun