[Upstream Catchup] Merge RC:master to master #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
RocketChat#452) Signed-off-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
…embertypo [FIX] Typo `addMemberToBeAddedByUsername` instead of `addMemberByUsername`
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.5 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix app status not updated correctly * Use app logger for warning * Fix linting issue * Change up the error message when an app disables itself Co-authored-by: Bradley Hilton <graywolf336@craftyn.com>
…#363) * Add custom fields to messageBuilder * Add tests to the addCustomField method and catch error when key contains a period
Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
* Create manager for button registry * Refactor definitions * Add the configuration extend * Add regiter buttons permission * Fix styles and add appId prop to button interface * Add activation bridge method for new buttons * New types * Refactor gulpfile * Add new interaction event * Fix gulpfile * Fix error when app doesn't exist * A few refactors * Rename label property and remove icon
This reverts commit a5683b1.
* Create manager for button registry * Refactor definitions * Add the configuration extend * Add regiter buttons permission * Fix styles and add appId prop to button interface * Add activation bridge method for new buttons * New types * Refactor gulpfile * Add new interaction event * Fix gulpfile * Fix error when app doesn't exist * A few refactors * Rename label property and remove icon
|
Close in favor of #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weekly Catchup PR to merge RC:master in master.