-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bcc to salesforce #5708
base: master
Are you sure you want to change the base?
Added bcc to salesforce #5708
Conversation
This does not add any way to enable/disable the BCC. It needs to include a UI as well. |
Apologies, I wasn't aware that the UI needed to be included. I will make sure to add the UI component. |
@ragesoss , please review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -15,6 +15,10 @@ def email(alert) | |||
unless @alert.sender_email.nil? | |||
params[:bcc] = @alert.sender_email # sender_email gives user email of the sender | |||
end | |||
if bcc_to_salesforce && !@alert.sender_email.nil? | |||
params[:bcc] ||= [] | |||
params[:bcc] << ENV['SALESFORCE_BCC_EMAIL'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest mirroring the implementation in ticket_notification_mailer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the code changes, can you please have a look at it?
What this PR does
It adds BCC to salesforce by default
Fixes issue #5700