Added bcc to salesforce #5708
Open
Added bcc to salesforce #5708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does not add any way to enable/disable the BCC. It needs to include a UI as well. |
Apologies, I wasn't aware that the UI needed to be included. I will make sure to add the UI component. |
|
By default If unchecked |
|
@ragesoss , please review this. |
ragesoss
reviewed
Mar 20, 2024
| @@ -15,6 +15,10 @@ def email(alert) | |||
| unless @alert.sender_email.nil? | |||
| params[:bcc] = @alert.sender_email # sender_email gives user email of the sender | |||
| end | |||
| if bcc_to_salesforce && !@alert.sender_email.nil? | |||
| params[:bcc] ||= [] | |||
| params[:bcc] << ENV['SALESFORCE_BCC_EMAIL'] | |||
There was a problem hiding this comment.
I suggest mirroring the implementation in ticket_notification_mailer.
There was a problem hiding this comment.
I have made the code changes, can you please have a look at it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
It adds BCC to salesforce by default
Fixes issue #5700