Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mapshed model output to HS export #2666

Closed
ajrobbins opened this issue Feb 19, 2018 · 5 comments
Closed

Add Mapshed model output to HS export #2666

ajrobbins opened this issue Feb 19, 2018 · 5 comments
Assignees
@rajadain
Labels
HydroShare Export WPF Funding Source: William Penn Foundation WPF 2-4
Milestone
3.13.18 Productio...

Comments

@ajrobbins
Copy link

As reported by @aufdenkampe , the HydroShare export currently does not include MapShed model output (hydrology table and water quality tables). Add csv's for those tables to the HS export.
@ajrobbins ajrobbins added 1 WPF Funding Source: William Penn Foundation HydroShare Export labels Feb 19, 2018
@ajrobbins ajrobbins added this to the 3.13.18 Production Release milestone Feb 19, 2018
@rajadain rajadain mentioned this issue Feb 19, 2018
Open
51 tasks
@ajrobbins ajrobbins modified the milestones: 3.13.18 Production Release, April Subbasin Release, 1.24 Feb 19, 2018
@rajadain rajadain assigned rajadain and unassigned rajadain Feb 23, 2018
@rajadain
Copy link
Member

There are more items in the results view than just the tables, such as summary statistics:

image

Should these also be included, or just the tables?

@ajrobbins
Copy link
Author

@aufdenkampe thoughts?

@ajrobbins
Copy link
Author

ajrobbins commented Feb 27, 2018 •
edited
Loading

Filename should be: model_multiyear_scenarioname_hydrology | waterquality
Should output as a csv exactly matching the UI

This was referenced Feb 27, 2018
Merged
Closed
Closed
@aufdenkampe
Copy link
Member

@rajadain, regarding additional summary statistics, can you append those to the CSVs, as extra columns, but with blanks for all the rows except the Total / Entire Watershed row?

@rajadain
Copy link
Member

Like this:

Sources Sediment Total Nitrogen Total Phosphorus Mean Flow (m3/year) Mean Flow (m3/s)
Total Loads (kg) 10,842,816.7 299,694.8 45,412.5 115,777,006 3.67
Loading Rates (kg/ha) 1,320.94 36.51 5.53
Mean Annual Concentration (mg/l) 93.65 2.59 0.39
Mean Low-Flow Concentration (mg/l) 99.41 2.05 0.48

?

rajadain added a commit that referenced this issue Feb 28, 2018
@rajadain
Add Mean Flow values to Water Quality Summary
e05b6bb 
Mean Flow values are included in the Water Quality tab of
MapShed projects, but is not included in any table, and thus
was not included in the CSVs generated for HydroShare export.

We add two extra columns to the Water Quality Summary table,
one for per year, one for per second, and include them in the
Totals row. Other rows in that table are empty in those two
columns.

See discussion for this here:
#2666 (comment)
rajadain added a commit that referenced this issue Feb 28, 2018
@rajadain
Add Mean Flow values to Water Quality Summary
2280c50 
Mean Flow values are included in the Water Quality tab of
MapShed projects, but is not included in any table, and thus
was not included in the CSVs generated for HydroShare export.

We add two extra columns to the Water Quality Summary table,
one for per year, one for per second, and include them in the
Totals row. Other rows in that table are empty in those two
columns.

See discussion for this here:
#2666 (comment)
@rajadain rajadain mentioned this issue Mar 5, 2018
Merged
rajadain added a commit that referenced this issue Mar 6, 2018
@rajadain
Merge pull request #2700 from WikiWatershed/tt/hydroshare-export-mode…
f20ce1c 
…l-tables-2

HydroShare Export: Properly Include Model Results as CSV

Connects #2666
Connects #2667
@rajadain rajadain closed this as completed Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajadain rajadain

Labels
HydroShare Export WPF Funding Source: William Penn Foundation WPF 2-4
Projects
None yet
Milestone
3.13.18 Production Release
Development

No branches or pull requests
3 participants
@rajadain @aufdenkampe @ajrobbins