This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
SUS-2120: Undeleting does not imply editing #13393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grunny
approved these changes
Jul 24, 2017
There was a problem hiding this comment.
Sure, I don't think we have many valid cases where someone can undelete a page they can't edit, but shouldn't be able to undelete it. Technically in the case of blogs, comments, and Wall, nearly all users who can undelete can also edit the comment pages, they just rely on a different edit permission, right?
We can also probably remove the two i18n messages that were added with this.
macbre
approved these changes
Jul 24, 2017
macbre
approved these changes
Jul 25, 2017
|
Tested and Accpeted |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines were added during last Core MW security backport. This assumption is not true with many of our features such as blogs, comments, Wall etc. I'm removing it so undeleting works properly.
https://wikia-inc.atlassian.net/browse/SUS-2120