This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Extension:SpecialCategoryIntersection rework #13457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszabo-wikia
suggested changes
Aug 3, 2017
| @@ -293,12 +289,13 @@ private function showFooter($out){ | |||
| // Examples are now kept in wikitext so that each wiki can have its own examples if it wishes. | |||
| $exampleText = wfMsg('categoryintersection-footer-examples'); | |||
| $rawExamples = explode("\n\n", $exampleText); | |||
| foreach($rawExamples as $singleExample){ | |||
| $examples = array_map(function($singleExample) { | |||
There was a problem hiding this comment.
There is no benefit to using array_map here, it is slower than the foreach loop and does not make the code more readable.
There was a problem hiding this comment.
Okay, I reverted it.
| if(!startsWith($cat, $this->CATEGORY_NS_PREFIX)){ | ||
| $html .= "<em>Warning: \"$cat\" does not start with \"{$this->CATEGORY_NS_PREFIX}\".</em><br/>\n"; | ||
| } | ||
| $categories[] = (!startsWith($cat, $this->CATEGORY_NS_PREFIX) and !startsWith($cat, NS_CATEGORY)) ? $this->CATEGORY_NS_PREFIX.$cat : $cat; |
There was a problem hiding this comment.
FANDOM follows MediaWiki's PHP coding conventions. Please ensure your contributions follow this coding style.
There was a problem hiding this comment.
no problem, I altered it to an if
shaedrich
commented
Aug 8, 2017
|
After internal discussion it was determined we cannot accept such feature requests for now to maintain compliance with the Pull Request Policy. |
|
Thank's for your explanation :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.