Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to plug the back end v2 curation API #139

Merged
merged 1 commit into from
Jan 22, 2018
Merged

Conversation

marfox
Copy link
Member

@marfox marfox commented Nov 14, 2017

the gadget (AKA tool version 1) now supports the version 2 back-end services /suggest and /curate, see https://www.wikidata.org/wiki/Wikidata:Primary_sources_tool#Architecture

@marfox marfox requested a review from Tpt November 14, 2017 15:54
@Tpt
Copy link
Collaborator

Tpt commented Nov 14, 2017

Great \o/! We should wait for the deployment on a VPS in order to don't break Wikimedia terms of uses.

Do you plan to implement JSON output in the backend? It would allow to clean up a lot the frontend by avoiding to to there the TSV -> JSON conversion.

You should also replace all the usages of the old backend to the new one in order to don't have to maintain 2 backends at the same time.

@marfox
Copy link
Member Author

marfox commented Nov 15, 2017

@Tpt , I replied yesterday via e-mail, but it hasn't shown up here, so pasting below.

Great \o/! We should wait for the deployment on a VPS in order to don't break Wikimedia terms of uses.

Sounds good.

Do you plan to implement JSON output in the backend?

Sure thing! The Wikidata JSON output is already implemented.
However, it is not trivial to refactor the current front end, as it heavily relies on the TSV format, with a considerable number of functions using it.
We would love to get your help here, ideally refactoring functions from high-level ones like matchClaims, down to lower-level ones like parseFreebaseClaims.

@Kiailandi Kiailandi merged commit 0d3c043 into master Jan 22, 2018
@Kiailandi Kiailandi deleted the v2-curation-api branch January 22, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants