Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mapbox Municipality Layer #131

Closed
HerziPinki opened this issue May 21, 2023 · 11 comments
Closed

Update Mapbox Municipality Layer #131

HerziPinki opened this issue May 21, 2023 · 11 comments
Assignees
Labels

Comments

@HerziPinki
Copy link
Collaborator

HerziPinki commented May 21, 2023

clicking the map fails to find objects, while entering the name of the same municipality works properly. This true for Gablitz, Purkersdorf and Mauerbach (and ev. more). See https://de.wikipedia.org/wiki/Wikipedia_Diskussion:WikiDaheim/2023#%E2%80%9EKein_Objekt_entspricht_deinen_Kriteren._Versuche_die_Filtereinstellungen_zu_%C3%A4ndern.%E2%80%9C

Message shown: "Kein Objekt entspricht deinen Kriteren. Versuche die Filtereinstellungen zu ändern".

The name of the municipality area clicked is shown in the input field as expected.

@HerziPinki HerziPinki added the bug label May 21, 2023
@HerziPinki
Copy link
Collaborator Author

@reiterbene is this a gui problem or server side problem?

@reiterbene
Copy link
Member

When clicking on the map the GKZ is provided as search query param. Via the Search it is the Wikidata-ID.
These municipailities seem to have an updated GKZ because of https://www.noe.gv.at/noe/Zahlen-Fakten/Gemeindekennziffern_WU.html
The Backend now seems to use these new GKZs.

e.g. Purkersdorf
The map has the municipailty saved as "32416". When returned via the Search Field (which searches by Wikidata-ID) returns a GKZ of "31952".
The Excel-File provides a mapping to the new GKZs.

There are two Solutions:

  • Update the Mapbox-Layer to the new GKZs
  • Use a mapping-table (either on the server or client-side)

@HerziPinki
Copy link
Collaborator Author

@reiterbene thanks for the analysis

we should go with correct GKZs and not introduce mapping tables. Reorganizing municipalities is mostly accompanied with change in GKZ, we must cope with this. In Lower Austria the GKZ of following municipalities have changed:

old | new | municipality
32401 | 30729 | Ebergassing
32402 | 30730 | Fischamend
32403 | 31949 | Gablitz
32404 | 31235 | Gerasdorf bei Wien
32405 | 30731 | Gramatneusiedl
32406 | 30732 | Himberg
32407 | 30733 | Klein-Neusiedl
32408 | 32144 | Klosterneuburg
32409 | 30734 | Lanzendorf
32410 | 30735 | Leopoldsdorf
32411 | 30736 | Maria-Lanzendorf
32412 | 31950 | Mauerbach
32413 | 30737 | Moosbrunn
32415 | 31951 | Pressbaum
32416 | 31952 | Purkersdorf
32417 | 30738 | Rauchenwarth
32418 | 30739 | Schwadorf
32419 | 30740 | Schwechat
32421 | 31953 | Tullnerbach
32423 | 31954 | Wolfsgraben
32424 | 30741 | Zwölfaxing

Can we fix it on the mapbox layer and how can this be done? The Denkmalliste contains the correct (new) GKZ in the header. While the Wikidata Entry does contain both GKZs, e.g. https://www.wikidata.org/wiki/Q674130 (is there a way to fix this in wikidata?) See also https://www.wikidata.org/wiki/User_talk:Mfchris84#GKZ

@reiterbene reiterbene changed the title clicking the map fails to find objects Update Mapbox Municipality Layer May 24, 2023
@HerziPinki
Copy link
Collaborator Author

another case: https://wikidaheim.at/Q683136 (Gutau, OÖ)
as far as I see, there was no change in municipality structure, but the behaviour is similar to Ahorn.
So this might be a separate issue. Please check.

@pixelhaufen
Copy link

Öblarn is on the map but not in search?

@HerziPinki
Copy link
Collaborator Author

another case: https://wikidaheim.at/Q683136 (Gutau, OÖ)
as far as I see, there was no change in municipality structure, but the behaviour is similar to Ahorn.
So this might be a separate issue. Please check.

Öblarn is on the map but not in search?

this is also true for Übelbach. So I suspect that German Umlauts at first position cause this behavior
Mödling is ok.

@HerziPinki
Copy link
Collaborator Author

a list of recent renamings of municipalities: https://de.wikipedia.org/wiki/Wikipedia:WikiProjekt_%C3%96sterreich/Liste_von_Umbenennungen_%C3%B6sterreichischer_Gemeinden
problematic cases:

  • cases for 2018 (and before?) seem to be ok.
  • no response / blank result: Ahorn, St. Stefan am Walde, Murfeld, Pfons, Mühlbachl
  • redirect Schwanberg -> Bad Schwanberg works (ok) - but still Schwanberg in the list of names of municipalities (should not be there); Leopoldsdorf im Marchfelde -> Leopoldsdorf im Marchfeld

When forward typing the lists of municipalities, can you handle "St. ..." and "Sankt ..." as identical?

@reiterbene
Copy link
Member

Updated Mappings:

Ebergassing: GKZ not Found (Mapbox GKZ: 32401) | Please enter correct GKZ:30729
Fischamend: GKZ not Found (Mapbox GKZ: 32402) | Please enter correct GKZ:30730
Gablitz: GKZ not Found (Mapbox GKZ: 32403) | Please enter correct GKZ:31949
Gerasdorf bei Wien: GKZ not Found (Mapbox GKZ: 32404) | Please enter correct GKZ:31235
Gramatneusiedl: GKZ not Found (Mapbox GKZ: 32405) | Please enter correct GKZ:30731
Himberg: GKZ not Found (Mapbox GKZ: 32406) | Please enter correct GKZ:30732
Klein-Neusiedl: GKZ not Found (Mapbox GKZ: 32407) | Please enter correct GKZ:30733
Klosterneuburg: GKZ not Found (Mapbox GKZ: 32408) | Please enter correct GKZ:32144
Lanzendorf: GKZ not Found (Mapbox GKZ: 32409) | Please enter correct GKZ:30734
Leopoldsdorf: GKZ not Found (Mapbox GKZ: 32410) | Please enter correct GKZ:30735
Maria-Lanzendorf: GKZ not Found (Mapbox GKZ: 32411) | Please enter correct GKZ:30736
Mauerbach: GKZ not Found (Mapbox GKZ: 32412) | Please enter correct GKZ:31950
Moosbrunn: GKZ not Found (Mapbox GKZ: 32413) | Please enter correct GKZ:30737
Pressbaum: GKZ not Found (Mapbox GKZ: 32415) | Please enter correct GKZ:31951
Purkersdorf: GKZ not Found (Mapbox GKZ: 32416) | Please enter correct GKZ:31952
Rauchenwarth: GKZ not Found (Mapbox GKZ: 32417) | Please enter correct GKZ:30738
Schwadorf: GKZ not Found (Mapbox GKZ: 32418) | Please enter correct GKZ:30739
Schwechat: GKZ not Found (Mapbox GKZ: 32419) | Please enter correct GKZ:30740
Tullnerbach: GKZ not Found (Mapbox GKZ: 32421) | Please enter correct GKZ:31953
Wolfsgraben: GKZ not Found (Mapbox GKZ: 32423) | Please enter correct GKZ:31954
Zwölfaxing: GKZ not Found (Mapbox GKZ: 32424) | Please enter correct GKZ:30741
Bruck-Waasen: GKZ not Found (Mapbox GKZ: ) | Please enter correct GKZ:40835
Peuerbach: GKZ not Found (Mapbox GKZ: 40819) | Please enter correct GKZ:40835
Afiesl: GKZ not Found (Mapbox GKZ: 41301) | Please enter correct GKZ:41346
Ahorn: GKZ not Found (Mapbox GKZ: 41302) | Please enter correct GKZ:41345
Helfenberg: GKZ not Found (Mapbox GKZ: 41310) | Please enter correct GKZ:41345
St. Stefan am Walde: GKZ not Found (Mapbox GKZ: 41335) | Please enter correct GKZ:41346
Schönegg: GKZ not Found (Mapbox GKZ: ) | Please enter correct GKZ:41628
Vorderweißenbach: GKZ not Found (Mapbox GKZ: 41625) | Please enter correct GKZ:41628
Sankt Veit in der Südsteiermark: GKZ not Found (Mapbox GKZ: 61056) | Please enter correct GKZ:61060
Straß in Steiermark: GKZ not Found (Mapbox GKZ: 61058) | Please enter correct GKZ:61061
Murfeld: GKZ not Found (Mapbox GKZ: 62347) | Please enter correct GKZ:61060
Matrei am Brenner: GKZ not Found (Mapbox GKZ: 70327) | Please enter correct GKZ:70370
Mühlbachl: GKZ not Found (Mapbox GKZ: 70330) | Please enter correct GKZ:70370
Pfons: GKZ not Found (Mapbox GKZ: 70341) | Please enter correct GKZ:70370

@HerziPinki
Copy link
Collaborator Author

HerziPinki commented Jun 26, 2023

Sankt Veit in der Südsteiermark: GKZ not Found (Mapbox GKZ: 61056) | Please enter correct GKZ:61060
Straß in Steiermark: GKZ not Found (Mapbox GKZ: 61058) | Please enter correct GKZ:61061
Murfeld: GKZ not Found (Mapbox GKZ: 62347) | Please enter correct GKZ:61060

list ok, except:
Murfeld was split into Sankt Veit in der Südsteiermark and Straß in Steiermark, so a simple redirect/change of GKZ will not work.

@reiterbene
Copy link
Member

As the map layer was not updated by mapbox the new boundaries are not represented on the map - so we have to assign Murfeld to one of those two, altought it was split. We can show a message with this information if necessary.

@HerziPinki
Copy link
Collaborator Author

As the map layer was not updated by mapbox the new boundaries are not represented on the map - so we have to assign Murfeld to one of those two, altought it was split. We can show a message with this information if necessary.

ok, we will live with that.
but please assign GKZ:61061 to Murfeld, as 4/5 of the former cadastral municipalities have been assigned to Straß in Steiermark.

reiterbene added a commit that referenced this issue Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants