-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter coordinates in GPX file based on current selection #95
Comments
The GPX-Link that is generated already passes the selected categories. Only the Properties-Settings (Missing Pictures/Description) do not affect the content of the GPX-File as these are filters the server isn't aware of. If we want to add those properties @pixelhaufen would have to implement it in the API first. |
Ok, thank you, I'll talk to Ruben then. I think being able to filter by missing pictures would be a keystone of this feature. |
Default is only objects with missing images and coordinates. Add &data=all for every object with coordinates. Please note that the wikidata part is in the moment under development and the gpx will be the last peace in the puzzle to the update. |
What I've done so far: If there is no filter selected (pictures/description) &data=all is attached. This should work in most cases. @pixelhaufen there are more filter criteria available to the user (missing pictures and/or missing description) so it is currently not possible to generate a 1:1 link. @BraveheartWikimedia does the current solution satisfy your requirements? |
Would work for me, depends on if Ruben can use this. |
Sorry, I have no idea how the gui-logic should be. For the gpx-api:
|
we have a third case: missing description which isn't represented by the gpx-api yet |
I know - but there is absolutely no use (at least that I'm aware of) for a gpx-file (which contains exactly what the photographers asked for) with the coordinates of objects that have no description. Even the source where it could be added is not part of the data and there is no way to find an object based on the coordinates to add the missing data... If it makes sense to send the call to return the objects with missing pictures if the user has only selected missing description is beyond my logic. |
Complaining user is still not satisfied: the only filter applied is that of 'missing images' (with coordinates, otherwise they cannot be displayed on a map). This is the main use case that should work properly. The gpx for Linz even shows more objects than the WikiDaheim App (unfiltered).
For each of the objects above there are three sources in Wikidaheim: the Denkmalliste, the WP article and Commons-Category. Commons-Category is unlikely to be a source (only true for empty categories). more data, still no clue. |
@pixelhaufen Is that something you're able to explain? Otherwise we'll have to go through it in a joint session to figure out what's going on here. |
Regarding the multiple entries in the GPX-File: On the Client-Side there is a merging-script that merges items with the same geocode. As this happens on the client side and the GPX-File is generated on the server-side the merging does not apply to that. (see WikiDaheim/src/redux/reducers/app.js Line 160 in 5ed90af
|
a case study: Hirtenberg (https://wikidaheim.at/Q687402), 33 objects, 26 thereof without image (on the frontend). In the gpx there are 90 objects listed (filtered with no image). Content: https://www.google.com/maps/d/edit?mid=1zJGbtvzYXSiOe_ylZmKCzEtrcV6r2qQ&ll=47.92996603682447%2C16.180869293384838&z=15
(for the station I added an image to wikidata P18 - so the behaviour might change) |
Solution: generate GPX file on the fly in fronte-end. |
Hi Bene,
would it be possible to filter the coordinates in the GPX filter based on the criteria set on screen? That would help limit the displayed data on map to the objects you actually want to go to, instead of getting everything.
BR, Philip
The text was updated successfully, but these errors were encountered: