Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin variable symbol as constraint #267

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Conversation

Wikunia
Copy link
Owner

@Wikunia Wikunia commented Jul 17, 2021

Implementation for #250
Currently it does not check whether the variables used are binary as I'm unsure how to do this.

@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #267 (f8f1bd4) into master (29ea78a) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   97.53%   97.58%   +0.05%     
==========================================
  Files          53       53              
  Lines        4419     4428       +9     
==========================================
+ Hits         4310     4321      +11     
+ Misses        109      107       -2     
Impacted Files Coverage Δ
src/MOI_wrapper/bool.jl 95.23% <100.00%> (+1.29%) ⬆️
src/ConstraintSolver.jl 99.14% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ea78a...f8f1bd4. Read the comment docs.

@Wikunia
Copy link
Owner Author

Wikunia commented Jul 18, 2021

Should probably allow

a := { b => {c}}

Edit: That doesn't seem to work here as c is a normal expr and I don't have access at the parse constraint call in that case

@Wikunia Wikunia merged commit 633ebbb into master Jul 19, 2021
@Wikunia Wikunia deleted the feature-bin-symbol-as-constraint branch July 19, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant