-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize to french #208
Localize to french #208
Conversation
Also added a brief how to localize guide in LOCALIZATION.md Removed unused and duplicate strings from uk and es.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -22,7 +22,7 @@ | |||
"No Results for “%@“" = "No Results for “%@“"; | |||
"Ok" = "Ok"; | |||
"Permit #" = "Permit #"; | |||
"Please, input name or licence" = "Please, input name or licence"; | |||
"Please, input name or licence" = "Please, input name or license"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to leave both sides the same until the localisation is done (that way your shell incantation will find that the phrase hasn't been localised yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just a mispelling in the English Translation, will submit a fix.
As for the missing phrases, I'll add them in, but also look into why "Boardings" isn't translated - it should be "Inspections"......
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
submitted a fix for this, now both sides (and the code) say "license".
Related to issue #35 |
Changing to new language: on duty/off duty to at sea/not at sea Found a bug where "search fishery" wasn't used, because it should be "search fisheries", and another issue where a period needed to be added to match the string in the code. Updated French: on duty/at sea but also the "Search EMS" string was too long.
and fixed a bug I introduced in BoardVesselButton.swift
Also: Removed "Cannot access reports" as that is not in the code. Note that these words are the same in English and French: Date Description Latitude Longitude Photo Type
script in LOCALIZATION now continues only if the previous part was successful, and doesn't leave trash files laying around.
gotta have 'em.
…h-ios into Localize_to_French
and mad props to Marie-France!
@am-MongoDB This is ready for your review (assuming checks pass, but it built on my machine!) @mfhan did the actual translating, and it's AWESOME. |
@am-MongoDB localization is complete, can you review? There is issue #210 to deal with ModalViewButton not using translations, and when that's fixed the modal buttons will use the new translations. Other than that I tested everything out. |
Localized except for the following (which are either hard to localize, or were added after we gave the translators the phrases:
"Cannot access reports"
"Please, input name or license"
"Issued to"
"Remove"
"It has been %@ hours after closing the application"
"It has been %@ hours after starting of your duty."
"Change profile picture"
"Access your login and password on the keychain"