Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit sorted dir-diff result as soon as preceding results get ready #603

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Emit sorted dir-diff result as soon as preceding results get ready #603

wants to merge 2 commits into from

Commits on Aug 2, 2024

  1. Apply --sort-paths prior to computing diffs 

    This ensures that the json output is also sorted.
    @yuja
    yuja committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    3b362e5 View commit details
    Browse the repository at this point in the history

  2. Emit sorted dir-diff result as soon as preceding results get ready 

    If the directory diff contains lots of changes across files, it's better to
emit earlier results incrementally.

The idea is borrowed from the following thread. The diff producer assigns
incremental index, and the consumer puts the results in BinaryHeap to reorder
them by index.
https://users.rust-lang.org/t/parallel-work-collected-sequentially/13504/3
    @yuja
    yuja committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    829ba54 View commit details
    Browse the repository at this point in the history