Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region of Interest (ROI) metadata #192

Closed
cpaniaguam opened this issue Feb 6, 2023 · 1 comment
Closed

Region of Interest (ROI) metadata #192

cpaniaguam opened this issue Feb 6, 2023 · 1 comment
Labels
help wanted Extra attention is needed nice to have

Comments

@cpaniaguam
Copy link
Member

Should the region of interest be metadata to be collected by the command line interface?

In
https://github.com/WilhelmusLab/ice-floe-tracker/blob/0076a08836b2de271f254bd2a6e3cc852acaf5f1/existing_code/final_2020.m#L301-L327 the land mask is cropped to some hard coded specs.

Should the pipeline assume the the images are going to be cropped to the correct size? If not, what should the correct format for this metadata be?

@mkkim400 @danielmwatkins @mmwilhelmus @mirestrepo @tdivoll

@cpaniaguam cpaniaguam added the help wanted Extra attention is needed label Feb 6, 2023
@cpaniaguam cpaniaguam self-assigned this Feb 6, 2023
@mirestrepo mirestrepo added the question Further information is requested label Jul 18, 2024
@cpaniaguam cpaniaguam added nice to have and removed question Further information is requested labels Jul 18, 2024
@danielmwatkins
Copy link
Contributor

I like the way that the landmask and satellite image are downloaded having the exact same dimensions as each other in the current code. It looks to me like the portion of code that you highlighted is where the image is cut into three pieces, which is not something we want to exactly recreate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed nice to have
Projects
Development

No branches or pull requests

3 participants