Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed microphone support for iOS 10 beta 3 #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aw8
Copy link

@aw8 aw8 commented Jul 29, 2016

Pull request #179 allowed games to run on iOS 10 beta 3, but stopped microphone support from working.
The reason that iNDS was crashing when attempting to run a game in iOS 10 seems to be a new requirement for there to be a plist entry for NSMicrophoneUsageDescription (see here: https://forums.developer.apple.com/thread/51985)

Removing the changes from the previous pull request and adding the entry mentioned above to the plist file seems to allow games to run in iOS 10 beta 3, with microphone support functioning.

However, there's a possible issue: game audio seems to cut out after a few seconds if the microphone is enabled. (I'm not sure whether this is a separate issue to getting microphone support working at all.)
Tested with Nintendogs: the audio cuts out soon after entering the screen where you can buy a dog for the first time. If a dog has already been purchased, audio cuts out when launching the game and reaching the initial 'Nintendogs' start screen. Disabling the microphone in iNDS settings restores game audio.

@jchenevey
Copy link

Thanks for the better fix - I'm still learning the ropes of iOS development.

As for audio cutting out, are there any warnings or errors printed to the console when it happens?

@aw8
Copy link
Author

aw8 commented Jul 30, 2016

No problem, I'm also very new to this!

When the audio cuts out in-game, there doesn't seem to be any console errors/warnings.
Audio seems to cut out when the following console message appears: "Microphone changed playing state to: 1" (which I assume is when the microphone is switched on)

If I pause the game (by opening up the settings panel in the top left), the microphone is switched off (there is a console message that says "Microphone changed playing state to: 0").
When I restart, the in-game audio works for a second, and then cuts out again as the microphone is switched back on.

@jchenevey
Copy link

Interesting. When I get a chance, I'll try to find where the code logs the mic state - it might help us figure out what's happening with the audio.

On Jul 29, 2016, at 8:11 PM, aw8 notifications@github.com wrote:

No problem, I'm also very new to this!

When the audio cuts out in-game, there doesn't seem to be any console errors/warnings.
Audio seems to cut out when the following console message appears: "Microphone changed playing state to: 1" (which I assume is when the microphone is switched on)

If I pause the game (by opening up the settings panel in the top left), the microphone is switched off (there is a console message that says "Microphone changed playing state to: 0").
When I restart, the in-game audio works for a second, and then cuts out again as the microphone is switched back on.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@aw8
Copy link
Author

aw8 commented Jul 30, 2016

As an aside, this problem doesn't seem to be restricted to iOS 10 beta 3: the in-game audio cuts out in the same way with microphone enabled on an iPhone 5 running iOS 9.3.3.

@jchenevey
Copy link

In the Xcode project, the mic state is logged in Main/DeSmuME/iOS/iNDSMicrophone.m on line 79. Unfortunately, I can't spot anything that might indicate why audio stops when the mic is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants