Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Italian language resources (readme/install/shell extension/GUI) #165

Merged
merged 6 commits into from
Jul 29, 2019
Merged

Conversation

bovirus
Copy link
Contributor

@bovirus bovirus commented Jul 29, 2019

No description provided.

@sdottaka sdottaka merged commit a27c97f into WinMerge:master Jul 29, 2019
@sdottaka
Copy link
Member

Thank you!

@bovirus
Copy link
Contributor Author

bovirus commented Jul 29, 2019

@sdottaka

Seems that there si a problem regarding installation of localized Readme text file.

the installer code

;Documentation
Source: ....\Docs\Users\ReadMe.txt; DestDir: {app}\Docs; Flags: comparetimestamp ignoreversion promptifolder; Components: Core

[Icons]
;Start Menu Icons
Name: {group}{cm:ReadMe}; Filename: {app}\Docs\ReadMe.txt; IconFileName: {win}\NOTEPAD.EXE

In this ways also if you have differnt Readme for different language seems that the instalelr install only Readnme (English).

@sdottaka
Copy link
Member

sdottaka commented Jul 29, 2019

I think it has been fixed by commit c548340

@bovirus
Copy link
Contributor Author

bovirus commented Jul 30, 2019

@sdottaka

Where can I download latest instalelr build to test it?

@sdottaka
Copy link
Member

We use AppVeyor, which automatically builds the installer when pushing source changes to the Bitbucket repository.
The latest installer is available at https://ci.appveyor.com/project/sdottaka/winmerge/build/artifacts.

@bovirus
Copy link
Contributor Author

bovirus commented Jul 30, 2019

@sdottaka

Two problem founds in the latest build of the installer.

The "Readme" (Italian) file at the end of the installation is showed wrongly about accented letters.
Please check if should be in ANSI or UTF-8 text coding (English file sue UTF-8 - not English one use ANSI).

WinMerge 2 16 4 0 - Readme (Italian)

The program link for "Readme" file (with Italian language selecetd for the installer) in WinMerge program group point to "Readme-Italian.txt" file that is not included in the program folder (sub-folder "Docs).

Quite strange because it show me before to close the installer.

@sdottaka
Copy link
Member

The problem has been fixed by commit 9354aab.

@bovirus
Copy link
Contributor Author

bovirus commented Jul 30, 2019

@sdottaka

First problem (accented letter in readme italian) fixed.

Seconf problem not fixed.

If I click on Leggimi (Readme Italian) it reported "Readme-Italian,.txt" not found,.
The installer didn't copy "Readme-Italian.txt" in "Doc" subfolder in Winmerge program directory.
IIn this "Doc" subfolder there is only "Readme.txt" (English) file.

@sdottaka
Copy link
Member

Sorry I missed it.
The second problem has been fixed by commit 80b5e2d

@bovirus
Copy link
Contributor Author

bovirus commented Jul 31, 2019

@sdottaka

Thanks. The latest build works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants