Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Ruby 2.4 #34

Merged
merged 2 commits into from
Apr 7, 2017
Merged

Support Ruby 2.4 #34

merged 2 commits into from
Apr 7, 2017

Conversation

fwininger
Copy link
Contributor

Remove deprecated warning

.rvm/gems/ruby-2.4.0/gems/rubyntlm-0.6.1/lib/net/ntlm/client/session.rb:39: warning: constant OpenSSL::Cipher::Cipher is deprecated
.rvm/gems/ruby-2.4.0/gems/rubyntlm-0.6.1/lib/net/ntlm/client/session.rb:128: warning: constant OpenSSL::Cipher::Cipher is deprecated
.rvm/gems/ruby-2.4.0/gems/rubyntlm-0.6.1/lib/net/ntlm/client/session.rb:138: warning: constant OpenSSL::Cipher::Cipher is deprecated

@fwininger
Add Ruby 2.4 in travis tests
88a01a1 
Signed-off-by: Florian Wininger <fw.centrale@gmail.com>
@fwininger
Fix Ruby 2.4 deprecated warnings
e6ff446 
Signed-off-by: Florian Wininger <fw.centrale@gmail.com>
mwrock
mwrock approved these changes Apr 7, 2017
View reviewed changes
Copy link
Member

@mwrock mwrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@mwrock mwrock merged commit 45f6f1a into WinRb:master Apr 7, 2017
@busterb busterb mentioned this pull request Apr 14, 2017
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwrock mwrock mwrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fwininger @mwrock