(maint) Replace erubis with erubi #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port over the changes included in winrm gem to replace the deprecated erubis gem with the more light weight erubi gem. This also avoids the [cwe](https://cwe.mitre.org/data/definitions/79.html) some static analysis tools will pick up for the erubis gem. Ported from WinRb/WinRM#300 author: @jrafanie
Pin rubocop < 0.69.0 (where they dropped support for ruby 2.2) and make suggested changes to maintain style compliance.
donoghuc
force-pushed
the
replace-erubis
branch
from
f98f06b
to
a4bfba7
Compare
|
Hmm, Still working through the rubocop frozen sting change.... DO NOT MERGE for now. |
When Rubocop added the frozen string literal optimization, assuming the buffer for the stream upload was a frozen string caused an exception. This commit removes the frozen string assumption from the file_transporter file.
donoghuc
commented
Nov 4, 2019
| @@ -451,6 +451,7 @@ def stream_upload(input_io, dest) | |||
| read_size = ((max_encoded_write - dest.length) / 4) * 3 | |||
| chunk = 1 | |||
| bytes = 0 | |||
| # Do not freeze this string | |||
| buffer = '' | |||
There was a problem hiding this comment.
Is there a different buffer we could use here? It appears the input_io.read method will not accept a stringio there. But I did not spend much time on it.
|
thanks so much for taking care of this! |
|
See also WinRb/winrm-elevated#29 .... are there any other gems that use erubis? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port over the changes included in winrm gem to replace the deprecated erubis gem with the more light weight erubi gem. This also avoids the cwe some static analysis tools will pick up for the erubis gem.
Ported from WinRb/WinRM#300 author: @jrafanie