[POC] Replace erubis with erubi #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasons: rails/rails#27757 We needed to implement the result method from erubis: https://www.rubydoc.info/gems/erubis/2.7.0/Erubis/RubyEvaluator#result-instance_method
jrafanie
changed the title
jrafanie
commented
Apr 5, 2019
| when NilClass | ||
| b = binding | ||
| else | ||
| raise ArgumentError |
There was a problem hiding this comment.
We can raise a more relevant message if needed
|
@mwrock Sorry to ping you directly, but in case you just missed this PR, I'd like to hear your opinion on replacing erubis with erubi. It's a concern because even if we're not using erubis with rails, just having erubis loaded by another gem causes a rails deprecation when loading rails templating engines. It seems like a good idea to drop erubis for all the reasons mentioned in the rails PR listed above, copied here for convenience: rails/rails#27757 |
|
👍 |
donoghuc
added a commit
to donoghuc/winrm-fs
that referenced
this pull request
Nov 4, 2019
Port over the changes included in winrm gem to replace the deprecated erubis gem with the more light weight erubi gem. This also avoids the [cwe](https://cwe.mitre.org/data/definitions/79.html) some static analysis tools will pick up for the erubis gem. Ported from WinRb/WinRM#300 author: @jrafanie
donoghuc
added a commit
to donoghuc/winrm-fs
that referenced
this pull request
Nov 4, 2019
Port over the changes included in winrm gem to replace the deprecated erubis gem with the more light weight erubi gem. This also avoids the [cwe](https://cwe.mitre.org/data/definitions/79.html) some static analysis tools will pick up for the erubis gem. Ported from WinRb/WinRM#300 author: @jrafanie
jrafanie
added a commit
to jrafanie/winrm-elevated
that referenced
this pull request
Nov 5, 2019
Adapted the change from: WinRb/WinRM#300 This grabs prior context or local variables, builds a string which set these variables, and evalulates them in the context of the binding. Note, this repo wasn't explicitly depending on erubis before but was trying to require it. I've also added erubi as a dependency so this gem can run standalone. Fixes WinRb#28
|
See also WinRb/winrm-elevated#29 .... are there any other gems that use erubis? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this pull request to see if this is something that would be ultimately accepted. It looks like people have been moving off of erubis because it's mostly unmaintained and more complicated.
This seems to have been influenced greatly by rails:
rails/rails#27757
We needed to implement the result method from erubis:
https://www.rubydoc.info/gems/erubis/2.7.0/Erubis/RubyEvaluator#result-instance_method
I got the tests to pass but I have no idea if I covered everything.