Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hackathon 2023 07 21 - Remove DRF - Iteration 4 (last) #277

Merged
merged 27 commits into from
Jul 22, 2023
Merged

Hackathon 2023 07 21 - Remove DRF - Iteration 4 (last) #277

merged 27 commits into from
Jul 22, 2023

Conversation

mofr
Copy link
Collaborator

@mofr mofr commented Jul 21, 2023 •
edited
Loading

Participants:

Changes:

  • DRF request and response are replaced with Django HttpRequest and HttpResponse
  • Authorization and CSRF protection are removed from the framework
  • Replaced APIClient with httpx in tests

pristupa and others added 14 commits July 21, 2023 19:35
@pristupa
Deprecate DRF request and response
6308955
@pristupa
Fix test
ac16c29
@mofr
SUSHI-13086 Replace drf APIClient with httpx
6d35e3b
@mofr
SUSHI-13086 Delete unnecessary csrf and auth stuff
84156d9
@mofr
SUSHI-13086 Replace low-level PagePosition tests with API tests
c6d1848
@mofr
SUSHI-13086 Replace low-level PagePosition tests with API tests
212f3ef
@mofr
SUSHI-13086 Replace low-level exception tests with test_api_with_exce…
c8ec109 
…ptions_throws_500
@mofr
SUSHI-13086 Fix headers assert in test_api_with_problem_exceptions
f4cfcb8
@mofr
SUSHI-13086 Remove unnecessary HttpRequest usage from test_return_res…
a99b754 
…ponse
@mofr
SUSHI-13086 Replace Request with HttpRequest
b3e5c50
@mofr
SUSHI-13086 Pass json instead of urlencoded form in test_request_body
aa8fd5b
@mofr
SUSHI-13086 Pass json instead of urlencoded form in test_create_djang…
ae5eade 
…o_urls_from_routes
@mofr
SUSHI-13086 Fix throttling since the user is optional in the request
3100efb
@mofr
Update changelog
164b30e
@mofr mofr requested a review from pristupa July 21, 2023 20:27
@mofr mofr changed the title Hackathon 2023 07 21 Hackathon 2023 07 21 - Remove DRF Jul 21, 2023
@mofr mofr changed the title Hackathon 2023 07 21 - Remove DRF Hackathon 2023 07 21 - Remove DRF - Iteration 4 (last) Jul 22, 2023
pristupa
pristupa previously approved these changes Jul 22, 2023
View reviewed changes
@mofr mofr requested a review from pristupa July 22, 2023 12:55
@mofr mofr added this to the Make Django non-hard dependency milestone Jul 22, 2023
@mofr mofr enabled auto-merge (squash) July 22, 2023 13:09
@mofr mofr merged commit 0603798 into master Jul 22, 2023
@mofr mofr deleted the hackathon-2023-07-21 branch July 22, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-optifino mike-optifino mike-optifino approved these changes

@mikhaillazko mikhaillazko mikhaillazko approved these changes

@andrey-berenda andrey-berenda Awaiting requested review from andrey-berenda

@EvgenySmekalin EvgenySmekalin Awaiting requested review from EvgenySmekalin

@pristupa pristupa Awaiting requested review from pristupa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Make Django non-hard dependency
Development

Successfully merging this pull request may close these issues.
4 participants
@mofr @pristupa @mikhaillazko @mike-optifino