Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UAPI socket for the macOS sandboxed Wireguard app #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nohajc
Copy link

@nohajc nohajc commented Sep 9, 2023

This change makes it possible to configure tunnels created by the App Store Wireguard UI using wg and wgctrl-go.

It's an implementation of this suggestion: #96 (comment)

Because the app is sandboxed, you cannot create the socket in its usual location (/var/run/wireguard).
It should be possible to configure an exception for the path but in practice it only works with regular files and not Unix domain sockets. That's why I create the socket inside the app's sandbox folder instead (~/Library/Containers/com.wireguard.macos.network-extension/Data).

I'm also submitting pull requests to modify wireguard-apple, wireguard-go and wireguard-tools to work with this alternative path.

WireGuard/wireguard-apple#27
WireGuard/wireguard-go#89
WireGuard/wireguard-tools#21

Signed-off-by: Jan Noha <nohajc@gmail.com>
@stv0g
Copy link
Contributor

stv0g commented Sep 11, 2023

Great contribution :)

I could really use this feature too. It would be great if we could get this merged.

@stv0g
Copy link
Contributor

stv0g commented Sep 25, 2023

@mdlayher, @zx2c4 Do you have suggestion how we could bring this forward? Maybe posting it on the mailinglist? Or send a patch that way?

@nohajc
Copy link
Author

nohajc commented Oct 2, 2023

I'm also interested in this. Should I initiate it? That is, sending the patches or perhaps asking for push access to the original repos' feature branches... I understand some of the repositories are only mirrors here on GitHub but I've seen previous pull requests being cherry-picked.

Anyway, it would be nice to hear from others whether they think this is useful and also satisfactory in the current form.

@mdlayher
Copy link
Member

mdlayher commented Oct 2, 2023

Starting a conversation on the mailing list seems like the appropriate place. It's not clear to me how these pieces fit together yet and I'd rather have a plan worked out before merging code here.

@nohajc
Copy link
Author

nohajc commented Oct 9, 2023

Starting a conversation on the mailing list seems like the appropriate place. It's not clear to me how these pieces fit together yet and I'd rather have a plan worked out before merging code here.

Ok, I sent an email to wireguard@lists.zx2c4.com, awaiting response. I assume it's not required to subscribe. I can't see my message in the archive yet, though I have no idea how often it is updated.

I didn't generate the git patches because it looked like I'd have to send one email for each repo which didn't seem very practical to me.

Please, let me know if there's anything else I should do. Thanks.

@mdlayher
Copy link
Member

mdlayher commented Oct 9, 2023

No worries about the patches at the moment. I just want to make sure we get Jason's thoughts on everything and how the pieces fit together.

@nohajc
Copy link
Author

nohajc commented Oct 25, 2023

Question: Do I have to subscribe to the mailing list first? Because I sent an email two weeks ago, haven't got any response and it didn't even show up in the archive.

@nohajc
Copy link
Author

nohajc commented Nov 17, 2023

@mdlayher @zx2c4 Ok, I really don't know what to do here. I sent an email to the mailing list twice. I got no response and it didn't even show up in the archive.

To be honest, this mailing list policy and apparent lack of any interest in PRs coming from github is kind of discouraging.
I've been more than willing to answer any questions regarding the suggested changes but nobody seems to care.

@zx2c4
Copy link
Member

zx2c4 commented Nov 17, 2023

I haven't had a chance to look into this yet. Sorry for the delay.

@nohajc
Copy link
Author

nohajc commented Jan 4, 2024

I haven't had a chance to look into this yet. Sorry for the delay.

I understand it's probably low priority but it's also a fairly small change...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants