Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup around ES6 #502

Merged
merged 5 commits into from
Mar 21, 2021
Merged

Conversation

aarranz
Copy link
Member

@aarranz aarranz commented Mar 19, 2021

Proposed changes

This PR makes some code clean ups, like configuring eslint to use the no-var and prefer-const options and improve the usage of ES6 classes on the code.

Types of changes

  • Refactoring (non-breaking change which improves code quality without changing the current behaviour)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This PR does not solve al the problems related to ES6 adherence, the rest of the needed clean ups will be addressed on further PR.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 88.595% when pulling 7be2a4a on aarranz:task/es6-classes-cleanup into 5943d56 on Wirecloud:develop.

@aarranz aarranz merged commit 1edc233 into Wirecloud:develop Mar 21, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants