Refactor repoIndex collection into a DB model #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
woodpig07
approved these changes
Jul 12, 2017
client/src/components/Header.js
Outdated
| @@ -39,6 +40,13 @@ export default class Header extends Component { | |||
|
|
|||
| componentDidMount() { | |||
| this.loadBasicRepoData() | |||
| setInterval(() => { | |||
There was a problem hiding this comment.
I think it's better to put this setInterval after fetchLatestIndex() is done, as fetchLatestIndex() would also involving getting the latest index.
There was a problem hiding this comment.
@woodpig07 Nice point! will do.
| @@ -1,7 +1,16 @@ | |||
| import GithubAPI from 'github-api' | |||
| import _ from 'lodash' | |||
| import Bluebird from 'bluebird' | |||
There was a problem hiding this comment.
Since you started using Bluebird, maybe it's better to replace all the native Promise with Bluebird in this file?
There was a problem hiding this comment.
Yes, it's my next step. Will leave it as it is now in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still WIP - DO NOT MERGELet me know if you want to collaborate, cause I may squash and force push commits.
[EDITED]
Ready to merge.
In this PR:
RepoFileEntryis created to save individual file entrytipCommitShais added to modelRepoIndexto track the tip commit of the branch/api/repository/updated-collectionsis added, which will only response modified/removed entries