-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SQLite to version 3.45.2 #1173
Conversation
The failing test: it('should work with an empty database', async function () {
this.db.close();
this.db = new Database();
const buffer = this.db.serialize();
expect(buffer).to.be.an.instanceof(Buffer);
writeFileSync("/tmp/empty.db", buffer);
expect(buffer.length).to.equal(0);
this.db.close();
this.db = new Database(buffer);
expect(this.db.serialize().length).to.equal(0);
}); The new behavior of SQLite is to actually emit a valid SQLite database, complete with a proper magick header:
I propose the assertion on empty databases should be modified to validate that there aren't any tables, and the buffer is less than or equal to 4096 bytes. Note that this change isn't mentioned in the SQLite release notes: https://sqlite.org/releaselog/3_45_2.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:+1
This is an automated pull request, updating SQLite to version
3.45.2
.