Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for attributes on links, images, and inline code spans #256

Merged
merged 24 commits into from
Mar 18, 2023

Conversation

Witiko
Copy link
Owner

@Witiko Witiko commented Jan 25, 2023

Closes #123.

Tasks

  • Complete link attribute support from jgm#36, see jgm#43. Add link attributes syntax extension (see also Pandoc).
  • Add inline code attributes syntax extension (see also Pandoc).
  • Add link and inline code attribute context renderers (see also Pandoc).
  • Add linkAttributes and inlineCodeAttributes Lua options.
    See example for linkAttributes Lua option in Image resizing  #50 (comment).
    Load the corresponding syntax extensions in M.new().
  • Add unit tests for inline code and link attributes.
  • Add default LaTeX renderers for image attribute contexts.

@Witiko Witiko added feature request lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation syntax extension Related to syntax extensions and dialects of markdown labels Jan 25, 2023
@Witiko Witiko added this to the 2.21.0 milestone Jan 25, 2023
@Witiko Witiko marked this pull request as draft January 25, 2023 13:34
@Witiko Witiko force-pushed the feature/attributes-on-links-images-codes-and-tables branch 5 times, most recently from ec7b51b to b2a462c Compare February 22, 2023 14:08
@Witiko Witiko modified the milestones: 2.21.0, 2.22.0 Feb 27, 2023
@Witiko Witiko force-pushed the feature/attributes-on-links-images-codes-and-tables branch from b2a462c to 0b22e5f Compare March 6, 2023 13:48
@Witiko Witiko force-pushed the feature/attributes-on-links-images-codes-and-tables branch from 0b22e5f to 994af07 Compare March 6, 2023 13:52
@Witiko Witiko force-pushed the feature/attributes-on-links-images-codes-and-tables branch 5 times, most recently from ae0897e to 3da75aa Compare March 13, 2023 18:41
@Witiko Witiko force-pushed the feature/attributes-on-links-images-codes-and-tables branch from 3da75aa to ee2128f Compare March 13, 2023 19:07
@Witiko Witiko force-pushed the feature/attributes-on-links-images-codes-and-tables branch from 2db246b to 73dcb6c Compare March 13, 2023 19:32
@Witiko Witiko force-pushed the feature/attributes-on-links-images-codes-and-tables branch from eedaa14 to a53ff0f Compare March 13, 2023 22:24
@Witiko Witiko force-pushed the feature/attributes-on-links-images-codes-and-tables branch from 603962f to 0eb356f Compare March 15, 2023 22:51
@Witiko Witiko force-pushed the feature/attributes-on-links-images-codes-and-tables branch from 4d3cf1d to 190c09e Compare March 18, 2023 14:45
@Witiko Witiko force-pushed the feature/attributes-on-links-images-codes-and-tables branch from 190c09e to 42287c2 Compare March 18, 2023 14:52
@Witiko Witiko added automerge This pull request will be automatically merged after continuous integration has succeeded and removed automerge This pull request will be automatically merged after continuous integration has succeeded labels Mar 18, 2023
@Witiko Witiko changed the title Add support for attributes on links, images, and inline codes Add support for attributes on links, images, and inline code spans Mar 18, 2023
@Witiko Witiko added the automerge This pull request will be automatically merged after continuous integration has succeeded label Mar 18, 2023
@Witiko Witiko marked this pull request as ready for review March 18, 2023 20:59
@Witiko Witiko merged commit 420baf9 into main Mar 18, 2023
@Witiko Witiko deleted the feature/attributes-on-links-images-codes-and-tables branch March 18, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge This pull request will be automatically merged after continuous integration has succeeded feature request lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation syntax extension Related to syntax extensions and dialects of markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for attributes on links, images, and codes
1 participant