-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto identifiers extensions #315
Auto identifiers extensions #315
Conversation
Thank you. Hopefully, I can review the PR shortly and we can have both syntax extensions in Markdown 3.0.0 ahead of schedule. |
tests/testfiles/lunamark-markdown/no-auto-identifiers-with-attributes.test
Outdated
Show resolved
Hide resolved
@lostenderman There are two significant conceptual issues with the current implementation: the handling of Unicode and preventing duplicate identifiers. There are also other minor issues that I discuss in my review. Due to the estimated extent of the necessary changes, I rescheduled this PR to version 3.1.0, which is scheduled to be released at the end of September. |
@lostenderman As discussed at the Discord channel, CI in draft pull requests now skips building the documentation and goes straight to unit tests. This should make it faster and significantly more helpful in development. For example, here are the test results for this PR: Admittedly, this does not tell us much about the source of the problem at hand, but it clearly outlines how we might reproduce the issue. Compared to the miles of unhelpful text previously produced by failing documentation, this seems much more useful. |
Closes #237 and #238.