Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto identifiers extensions #315

Closed

Conversation

lostenderman
Copy link
Collaborator

Closes #237 and #238.

@Witiko Witiko added lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation syntax extension Related to syntax extensions and dialects of markdown labels Aug 1, 2023
@Witiko
Copy link
Owner

Witiko commented Aug 1, 2023

Thank you. Hopefully, I can review the PR shortly and we can have both syntax extensions in Markdown 3.0.0 ahead of schedule.

@Witiko Witiko added this to the 3.0.0 milestone Aug 1, 2023
markdown.dtx Outdated Show resolved Hide resolved
markdown.dtx Outdated Show resolved Hide resolved
markdown.dtx Outdated Show resolved Hide resolved
examples/optex.tex Outdated Show resolved Hide resolved
markdown.dtx Outdated Show resolved Hide resolved
tests/testfiles/lunamark-markdown/header-attributes.test Outdated Show resolved Hide resolved
@Witiko Witiko modified the milestones: 3.0.0, 3.1.0 Aug 12, 2023
@Witiko
Copy link
Owner

Witiko commented Aug 12, 2023

@lostenderman There are two significant conceptual issues with the current implementation: the handling of Unicode and preventing duplicate identifiers. There are also other minor issues that I discuss in my review. Due to the estimated extent of the necessary changes, I rescheduled this PR to version 3.1.0, which is scheduled to be released at the end of September.

@Witiko Witiko marked this pull request as draft August 12, 2023 12:23
@Witiko
Copy link
Owner

Witiko commented Aug 25, 2023

@lostenderman As discussed at the Discord channel, CI in draft pull requests now skips building the documentation and goes straight to unit tests. This should make it faster and significantly more helpful in development. For example, here are the test results for this PR:

image

Admittedly, this does not tell us much about the source of the problem at hand, but it clearly outlines how we might reproduce the issue. Compared to the miles of unhelpful text previously produced by failing documentation, this seems much more useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation syntax extension Related to syntax extensions and dialects of markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Pandoc auto_identifiers syntax extension
2 participants