Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include developer tools in development Docker image #374

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Include developer tools in development Docker image #374

merged 2 commits into from
Nov 22, 2023

Conversation

Witiko
Copy link
Owner

@Witiko Witiko commented Nov 22, 2023

Development is made easier by including developer tools such as less and vim directly in the development Docker image. This pull request separates the NO_DOCUMENTATION Make parameter to DOCKER_DEV_IMAGE, which is passed to the docker build command and the NO_DOCUMENTATION Make parameter, which is set internally by the Dockerfile.

@Witiko Witiko added docker Related to the Docker image quality of life Related to quality-of-life improvements to the interface labels Nov 22, 2023
@Witiko Witiko added this to the 3.3.0 milestone Nov 22, 2023
@Witiko Witiko self-assigned this Nov 22, 2023
@Witiko Witiko marked this pull request as ready for review November 22, 2023 15:17
@Witiko Witiko merged commit 052deec into main Nov 22, 2023
@Witiko Witiko deleted the feature/include-dev-tools-in-dev-image branch November 22, 2023 15:21
@Witiko Witiko modified the milestones: 3.3.0, 3.2.1 Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Witiko Witiko

Labels
docker Related to the Docker image quality of life Related to quality-of-life improvements to the interface
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
1 participant
@Witiko