Do not end paragraph before ::: in fenced divs
#431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in <Witiko#403 (comment)>.
Witiko
added
bug
lua
Witiko
reviewed
Apr 3, 2024
Witiko
reviewed
Apr 3, 2024
Witiko
requested changes
Apr 3, 2024
There was a problem hiding this comment.
This PR seems to break the test file paragraph-separators.test:
Testfile testfiles/lunamark-markdown/paragraph-separators.test:
Some commands produced unexpected outputs:
- Command context --once --luatex --nonstopmode test.tex produced unexpected output with the following diff:
*** /tmp/tmplaip2a0s/test-expected-024.log
--- /tmp/tmplaip2a0s/test-actual-024.log
***************
*** 57,64 ****
olEndTight
blockQuoteEnd
interblockSeparator
! BEGIN fencedDivAttributeContext
! attributeClassName: fenced-div
paragraphSeparator
paragraphSeparator
interblockSeparator
--- 57,63 ----
olEndTight
blockQuoteEnd
interblockSeparator
! softLineBreak
paragraphSeparator
paragraphSeparator
interblockSeparator
***************
*** 73,81 ****
olItemWithNumber: 1
olItemEnd
olItemWithNumber: 2
olItemEnd
olEndTight
- END fencedDivAttributeContext
interblockSeparator
ulBegin
ulItem
--- 72,80 ----
olItemWithNumber: 1
olItemEnd
olItemWithNumber: 2
+ softLineBreak
olItemEnd
olEndTight
interblockSeparator
ulBegin
ulItem
For more information, see the previous CI results from this PR.
Witiko
reviewed
Apr 3, 2024
Witiko
reviewed
Apr 3, 2024
Witiko
reviewed
Apr 3, 2024
Witiko
approved these changes
Apr 3, 2024
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP]
Added explicit continuation line flag to help the fenced div to properly close.