Identify wrong interpreted tag ids #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change enables the transaction parser to identify tag ids which seem to be valid but are artefacts of line wraps in the content of another tag. This occurs if the content contains character sequences like ...12:23:43... which happens to be a timestamp but looks like a tag id when wrapped unfortunatly like: 12\n\r :12:43 --> invalid tag id :12:
|
heading to close coverage gap... |
|
Great solution, or at least as good as possible :) Thanks for all the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change enables the transaction parser to identify
tag ids which seem to be valid but are artefacts of line wraps
in the content of another tag. This occurs if the content contains
character sequences like ...12:23:43... which happens to be a
timestamp but looks like a tag id when wrapped unfortunatly like:
12\n\r
:12:43 --> invalid tag id :12:
Looks like other implementations do not check this either (e.g. aqbanking, hbci4java)