Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry_date for transactions booked in the next year #67

Closed
wants to merge 1 commit into from
Closed

Fix entry_date for transactions booked in the next year #67

wants to merge 1 commit into from

Conversation

cfstras
Copy link

@cfstras cfstras commented Jan 8, 2019

when entry_month is 1, and month is 12, we must assume that the
transaction was booked in the next year.

Fixes #17.

when entry_month is 1, and month is 12, we must assume that the
transaction was booked in the next year.

Fixes #17.
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 9e72984 on cfstras:fix_year_end_entry_date into e418f2c on WoLpH:develop.

@jelle-eastground
Copy link

This isn't a complete fix. The entry_date could be before the date, for instance a statement line that begins with

:61:1901011231C1

Maybe you could also check the other way around, so

data['date'].month == 1 and entry_date.month = 12

and then decrease the year of the entry_date by 1?

@wolph
Copy link
Owner

wolph commented Jan 9, 2019

I'm actually working on a fixed based on @jelle-eastground his suggestion. It's just a bit of work getting all the tests working with it :)

Stay tuned

@wolph
Copy link
Owner

wolph commented Jan 10, 2019

Thanks for the help @cfstras :) I've implemented a similar fix from @jelle-eastground (was working on it for the last couple of days, the testing part was bugging me).

@wolph wolph closed this Jan 10, 2019
@cfstras cfstras deleted the fix_year_end_entry_date branch January 11, 2019 08:40
@cfstras
Copy link
Author

cfstras commented Jan 11, 2019

Thanks for the quick turnaround! Was not expecting that :)
I'll test it in our next billing cycle ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants