Rename check to is_closed #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename method: check => is_closed -> clarify for return value(boolean) - add sphinx-doc at is_closed method
- apply changed name: check -> is_closed
|
For the sake of backwards compatibility the check method needs to stay. But it could simply wrap the |
|
I understood. In that cases, the method needs some docs :) |
Codecov Report
@@ Coverage Diff @@
## develop #90 +/- ##
======================================
Coverage 100% 100%
======================================
Files 5 5
Lines 490 490
Branches 57 57
======================================
Hits 490 490
Continue to review full report at Codecov.
|
split check method into is_closed
rolled back from is_closed to check
|
I simply wrapped 'is_closed' method. so you can use them in check method as a check routines. |
|
Looks great. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.